Fix loading files with spaces - fixes #5437

Author: mstoykov

internal/cmd/test_load.go

@@ -243,20 +243,25 @@ func analyseUseContraints(imports []string, fileSystems map[string]fsext.Fs, dep
 		}
 		u, err := url.Parse(imported)
 		if err != nil {
-			panic(err)
+			return err
 		}
 		// We always have URLs here with scheme and everything
 		_, path, _ := strings.Cut(imported, "://")
 		if u.Scheme == "https" {
 			path = "/" + path
 		}
+		path, err = url.PathUnescape(filepath.FromSlash(path))
+		if err != nil {
+			return err
+		}
+
 		data, err := fsext.ReadFile(fileSystems[u.Scheme], path)
 		if err != nil {
-			panic(err)
+			return err
 		}
 		err = processUseDirectives(imported, data, deps)
 		if err != nil {
-			panic(err)
+			return err
 		}
 	}
 	return nil

internal/cmd/tests/cmd_run_test.go

@@ -3170,3 +3170,32 @@ func TestMachineReadableSummary(t *testing.T) {
 		assertSummaryExport(t, string(summaryExport))
 	})
 }
+
+func TestSpaceInPath(t *testing.T) {
+	t.Parallel()
+	depScript := `
+		export default function() {
+			let p = 42;
+			return p;
+		}
+	`
+	mainScript := `
+		import bar from "./foo bar.js";
+		let s = "something";
+		export default function() {
+			console.log(s, bar());
+		};
+	`
+
+	ts := NewGlobalTestState(t)
+	require.NoError(t, fsext.WriteFile(ts.FS, filepath.Join(ts.Cwd, "test me.js"), []byte(mainScript), 0o644))
+	require.NoError(t, fsext.WriteFile(ts.FS, filepath.Join(ts.Cwd, "foo bar.js"), []byte(depScript), 0o644))
+
+	ts.CmdArgs = []string{"k6", "run", "--quiet", "test me.js"}
+
+	cmd.ExecuteWithGlobalState(ts.GlobalState)
+
+	stderr := ts.Stderr.String()
+	t.Log(stderr)
+	assert.Contains(t, stderr, `something 42`)
+}