Browser: Fix getBy* when using quotes inside name (#5374)

Author: AgnesToulet

internal/js/modules/k6/browser/browser/page_mapping.go

@@ -5,6 +5,7 @@ import (
 	"errors"
 	"fmt"
 	"reflect"
+	"strings"
 	"time"
 
 	"github.com/grafana/sobek"
@@ -749,9 +750,9 @@ func parseStringOrRegex(v sobek.Value, doubleQuote bool) string {
 	switch v.ExportType() {
 	case reflect.TypeOf(stringType): // text values require quotes
 		if doubleQuote {
-			a = `"` + v.String() + `"`
+			a = `"` + strings.ReplaceAll(v.String(), `"`, `\"`) + `"`
 		} else {
-			a = `'` + v.String() + `'`
+			a = `'` + strings.ReplaceAll(v.String(), `'`, `\'`) + `'`
 		}
 	case reflect.TypeOf(map[string]interface{}(nil)): // JS RegExp
 		a = v.String() // No quotes

internal/js/modules/k6/browser/browser/page_mapping_test.go

@@ -34,6 +34,10 @@ func TestParseStringOrRegex(t *testing.T) {
 		{name: "null", input: mk(`null`), doubleQuote: false, want: `null`},
 		{name: "undefined", input: mk(`undefined`), doubleQuote: false, want: `undefined`},
 		{name: "undefined", input: mk(``), doubleQuote: false, want: `undefined`},
+		{name: "string_with_single_quote", input: mk(`'abc\''`), doubleQuote: false, want: `'abc\''`},
+		{name: "string_with_single_quote", input: mk(`'abc\''`), doubleQuote: true, want: `"abc'"`},
+		{name: "string_with_double_quote", input: mk(`'abc"'`), doubleQuote: false, want: `'abc"'`},
+		{name: "string_with_double_quote", input: mk(`'abc"'`), doubleQuote: true, want: `"abc\""`},
 	}
 
 	for _, tc := range tests {