fix(gcp_exporter): preserve colons in extra_filters filter expressions #5018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR fixes an issue in the
prometheus.exporter.gcpcomponent where colon (:) characters insideextra_filtersvalues were being removed due to the previous parsing logic. By switching tostrings.SplitN(filter, ":", 2), colons inside filter expressions (e.g., project_id:database_name) are now preserved correctly.Which issue(s) this PR fixes
Fixes #4186
Notes to the Reviewer
The previous implementation relied on
utils.SplitExtraFilter, which incorrectly removed colon characters from filter expressions. The updated logic only splits on the first colon, ensuring that metric prefix extraction remains correct while preserving all remaining colons in the filter query. No behavior changes outside ofextra_filtersparsing.PR Checklist