Skip to content

Commit b8b5546

Browse files
ptodevthampiotr
andauthored
Fix metric renames for otelcol, update RC version (#1719)
* Update RC version, fix OTEL metric renames (#1713) * Reword --------- Co-authored-by: Piotr <[email protected]>
1 parent 654ff49 commit b8b5546

File tree

9 files changed

+40
-37
lines changed

9 files changed

+40
-37
lines changed

CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,13 @@ This document contains a historical list of changes between releases. Only
77
changes that impact end-user behavior are listed; changes to documentation or
88
internal API changes are not present.
99

10-
v1.4.0-rc.2
10+
v1.4.0-rc.3
1111
-----------------
1212
### Breaking changes
1313

14+
- Some debug metrics for `otelcol` components have changed. (@thampiotr)
15+
For example, `otelcol.exporter.otlp`'s `exporter_sent_spans_ratio_total` metric is now `otelcol_exporter_sent_spans_total`.
16+
1417
- [otelcol.processor.transform] The functions `convert_sum_to_gauge` and `convert_gauge_to_sum` must now be used in the `metric` `context` rather than in the `datapoint` context.
1518
https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34567 (@wildum)
1619

docs/sources/reference/components/otelcol/otelcol.exporter.awss3.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,10 @@ information.
142142

143143
## Debug metrics
144144

145-
* `exporter_sent_spans_ratio_total` (counter): Number of spans successfully sent to destination.
146-
* `exporter_send_failed_spans_ratio_total` (counter): Number of spans in failed attempts to send to destination.
147-
* `exporter_queue_capacity_ratio` (gauge): Fixed capacity of the retry queue (in batches).
148-
* `exporter_queue_size_ratio` (gauge): Current size of the retry queue (in batches).
145+
* `otelcol_exporter_sent_spans_total` (counter): Number of spans successfully sent to destination.
146+
* `otelcol_exporter_send_failed_spans_total` (counter): Number of spans in failed attempts to send to destination.
147+
* `otelcol_exporter_queue_capacity` (gauge): Fixed capacity of the retry queue (in batches).
148+
* `otelcol_exporter_queue_size` (gauge): Current size of the retry queue (in batches).
149149
* `rpc_client_duration_milliseconds` (histogram): Measures the duration of inbound RPC.
150150
* `rpc_client_request_size_bytes` (histogram): Measures size of RPC request messages (uncompressed).
151151
* `rpc_client_requests_per_rpc` (histogram): Measures the number of messages received per RPC. Should be 1 for all non-streaming RPCs.

docs/sources/reference/components/otelcol/otelcol.exporter.otlp.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -172,10 +172,10 @@ information.
172172

173173
## Debug metrics
174174

175-
* `exporter_sent_spans_ratio_total` (counter): Number of spans successfully sent to destination.
176-
* `exporter_send_failed_spans_ratio_total` (counter): Number of spans in failed attempts to send to destination.
177-
* `exporter_queue_capacity_ratio` (gauge): Fixed capacity of the retry queue (in batches)
178-
* `exporter_queue_size_ratio` (gauge): Current size of the retry queue (in batches)
175+
* `otelcol_exporter_sent_spans_total` (counter): Number of spans successfully sent to destination.
176+
* `otelcol_exporter_send_failed_spans_total` (counter): Number of spans in failed attempts to send to destination.
177+
* `otelcol_exporter_queue_capacity` (gauge): Fixed capacity of the retry queue (in batches)
178+
* `otelcol_exporter_queue_size` (gauge): Current size of the retry queue (in batches)
179179
* `rpc_client_duration_milliseconds` (histogram): Measures the duration of inbound RPC.
180180
* `rpc_client_request_size_bytes` (histogram): Measures size of RPC request messages (uncompressed).
181181
* `rpc_client_requests_per_rpc` (histogram): Measures the number of messages received per RPC. Should be 1 for all non-streaming RPCs.

docs/sources/reference/components/otelcol/otelcol.processor.batch.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -136,11 +136,11 @@ information.
136136

137137
## Debug metrics
138138

139-
* `processor_batch_batch_send_size_bytes` (histogram): Number of bytes in batch that was sent.
140-
* `processor_batch_batch_send_size_ratio` (histogram): Number of units in the batch.
141-
* `processor_batch_metadata_cardinality_ratio` (gauge): Number of distinct metadata value combinations being processed.
142-
* `processor_batch_timeout_trigger_send_ratio_total` (counter): Number of times the batch was sent due to a timeout trigger.
143-
* `processor_batch_batch_size_trigger_send_ratio_total` (counter): Number of times the batch was sent due to a size trigger.
139+
* `otelcol_processor_batch_batch_send_size_bytes` (histogram): Number of bytes in batch that was sent.
140+
* `otelcol_processor_batch_batch_send_size` (histogram): Number of units in the batch.
141+
* `otelcol_processor_batch_metadata_cardinality` (gauge): Number of distinct metadata value combinations being processed.
142+
* `otelcol_processor_batch_timeout_trigger_send_total` (counter): Number of times the batch was sent due to a timeout trigger.
143+
* `otelcol_processor_batch_batch_size_trigger_send_total` (counter): Number of times the batch was sent due to a size trigger.
144144

145145
## Examples
146146

docs/sources/reference/components/otelcol/otelcol.processor.deltatocumulative.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,13 @@ Name | Type | Description
8989

9090
## Debug metrics
9191

92-
* `processor_deltatocumulative_streams_tracked` (gauge): Number of streams currently tracked by the aggregation state.
93-
* `processor_deltatocumulative_streams_limit` (gauge): Upper limit of tracked streams.
94-
* `processor_deltatocumulative_streams_evicted` (counter): Total number of streams removed from tracking to ingest newer streams.
95-
* `processor_deltatocumulative_streams_max_stale` (gauge): Duration without new samples after which streams are dropped.
96-
* `processor_deltatocumulative_datapoints_processed` (counter): Total number of datapoints processed (successfully or unsuccessfully).
97-
* `processor_deltatocumulative_datapoints_dropped` (counter): Faulty datapoints that were dropped due to the reason given in the `reason` label.
98-
* `processor_deltatocumulative_gaps_length` (counter): Total length of all gaps in the streams, such as being due to lost in transit.
92+
* `otelcol_deltatocumulative_streams_tracked` (gauge): Number of streams currently tracked by the aggregation state.
93+
* `otelcol_deltatocumulative_streams_limit` (gauge): Upper limit of tracked streams.
94+
* `otelcol_deltatocumulative_streams_evicted` (counter): Total number of streams removed from tracking to ingest newer streams.
95+
* `otelcol_deltatocumulative_streams_max_stale_seconds` (gauge): Duration without new samples after which streams are dropped.
96+
* `otelcol_deltatocumulative_datapoints_processed` (counter): Total number of datapoints processed (successfully or unsuccessfully).
97+
* `otelcol_deltatocumulative_datapoints_dropped` (counter): Faulty datapoints that were dropped due to the reason given in the `reason` label.
98+
* `otelcol_deltatocumulative_gaps_length` (counter): Total length of all gaps in the streams, such as being due to lost in transit.
9999

100100
## Examples
101101

docs/sources/reference/components/otelcol/otelcol.receiver.otlp.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,8 @@ information.
197197

198198
## Debug metrics
199199

200-
* `receiver_accepted_spans_ratio_total` (counter): Number of spans successfully pushed into the pipeline.
201-
* `receiver_refused_spans_ratio_total` (counter): Number of spans that could not be pushed into the pipeline.
200+
* `otelcol_receiver_accepted_spans_total` (counter): Number of spans successfully pushed into the pipeline.
201+
* `otelcol_receiver_refused_spans_total` (counter): Number of spans that could not be pushed into the pipeline.
202202
* `rpc_server_duration_milliseconds` (histogram): Duration of RPC requests from a gRPC server.
203203
* `rpc_server_request_size_bytes` (histogram): Measures size of RPC request messages (uncompressed).
204204
* `rpc_server_requests_per_rpc` (histogram): Measures the number of messages received per RPC. Should be 1 for all non-streaming RPCs.

docs/sources/set-up/deploy.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,9 @@ This similarity is because most {{< param "PRODUCT_NAME" >}} components used for
146146
#### When to scale
147147

148148
To decide whether scaling is necessary, check metrics such as:
149-
* `receiver_refused_spans_ratio_total` from receivers such as `otelcol.receiver.otlp`.
150-
* `processor_refused_spans_ratio_total` from processors such as `otelcol.processor.batch`.
151-
* `exporter_send_failed_spans_ratio_total` from exporters such as `otelcol.exporter.otlp` and `otelcol.exporter.loadbalancing`.
149+
* `otelcol_receiver_refused_spans_total` from receivers such as `otelcol.receiver.otlp`.
150+
* `otelcol_receiver_refused_spans_total` from processors such as `otelcol.processor.batch`.
151+
* `otelcol_exporter_send_failed_spans_total` from exporters such as `otelcol.exporter.otlp` and `otelcol.exporter.loadbalancing`.
152152

153153
#### Stateful and stateless components
154154

operations/alloy-mixin/alerts/opentelemetry.libsonnet

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ local alert = import './utils/alert.jsonnet';
1111
alert.newRule(
1212
'OtelcolReceiverRefusedSpans',
1313
if enableK8sCluster then
14-
'sum by (cluster, namespace, job) (rate(receiver_refused_spans_ratio_total{}[1m])) > 0'
14+
'sum by (cluster, namespace, job) (rate(otelcol_receiver_refused_spans_total{}[1m])) > 0'
1515
else
16-
'sum by (job) (rate(receiver_refused_spans_ratio_total{}[1m])) > 0'
16+
'sum by (job) (rate(otelcol_receiver_refused_spans_total{}[1m])) > 0'
1717
,
1818
'The receiver could not push some spans to the pipeline.',
1919
'The receiver could not push some spans to the pipeline under job {{ $labels.job }}. This could be due to reaching a limit such as the ones imposed by otelcol.processor.memory_limiter.',
@@ -25,9 +25,9 @@ local alert = import './utils/alert.jsonnet';
2525
alert.newRule(
2626
'OtelcolExporterFailedSpans',
2727
if enableK8sCluster then
28-
'sum by (cluster, namespace, job) (rate(exporter_send_failed_spans_ratio_total{}[1m])) > 0'
28+
'sum by (cluster, namespace, job) (rate(otelcol_exporter_send_failed_spans_total{}[1m])) > 0'
2929
else
30-
'sum by (job) (rate(exporter_send_failed_spans_ratio_total{}[1m])) > 0'
30+
'sum by (job) (rate(otelcol_exporter_send_failed_spans_total{}[1m])) > 0'
3131
,
3232
'The exporter failed to send spans to their destination.',
3333
'The exporter failed to send spans to their destination under job {{ $labels.job }}. There could be an issue with the payload or with the destination endpoint.',

operations/alloy-mixin/dashboards/opentelemetry.libsonnet

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ local stackedPanelMixin = {
4444
panel.withQueries([
4545
panel.newQuery(
4646
expr= |||
47-
rate(receiver_accepted_spans_ratio_total{%(instanceSelector)s}[$__rate_interval])
47+
rate(otelcol_receiver_accepted_spans_total{%(instanceSelector)s}[$__rate_interval])
4848
||| % $._config,
4949
//TODO: How will the dashboard look if there is more than one receiver component? The legend is not unique enough?
5050
legendFormat='{{ pod }} / {{ transport }}',
@@ -62,7 +62,7 @@ local stackedPanelMixin = {
6262
panel.withQueries([
6363
panel.newQuery(
6464
expr= |||
65-
rate(receiver_refused_spans_ratio_total{%(instanceSelector)s}[$__rate_interval])
65+
rate(otelcol_receiver_refused_spans_total{%(instanceSelector)s}[$__rate_interval])
6666
||| % $._config,
6767
legendFormat='{{ pod }} / {{ transport }}',
6868
),
@@ -100,7 +100,7 @@ local stackedPanelMixin = {
100100
panel.withQueries([
101101
panel.newQuery(
102102
expr= |||
103-
sum by (le) (increase(processor_batch_batch_send_size_ratio_bucket{%(instanceSelector)s}[$__rate_interval]))
103+
sum by (le) (increase(otelcol_processor_batch_batch_send_size_bucket{%(instanceSelector)s}[$__rate_interval]))
104104
||| % $._config,
105105
format='heatmap',
106106
legendFormat='{{le}}',
@@ -119,7 +119,7 @@ local stackedPanelMixin = {
119119
panel.withQueries([
120120
panel.newQuery(
121121
expr= |||
122-
processor_batch_metadata_cardinality_ratio{%(instanceSelector)s}
122+
otelcol_processor_batch_metadata_cardinality{%(instanceSelector)s}
123123
||| % $._config,
124124
legendFormat='{{ pod }}',
125125
),
@@ -134,7 +134,7 @@ local stackedPanelMixin = {
134134
panel.withQueries([
135135
panel.newQuery(
136136
expr= |||
137-
rate(processor_batch_timeout_trigger_send_ratio_total{%(instanceSelector)s}[$__rate_interval])
137+
rate(otelcol_processor_batch_timeout_trigger_send_total{%(instanceSelector)s}[$__rate_interval])
138138
||| % $._config,
139139
legendFormat='{{ pod }}',
140140
),
@@ -156,7 +156,7 @@ local stackedPanelMixin = {
156156
panel.withQueries([
157157
panel.newQuery(
158158
expr= |||
159-
rate(exporter_sent_spans_ratio_total{%(instanceSelector)s}[$__rate_interval])
159+
rate(otelcol_exporter_sent_spans_total{%(instanceSelector)s}[$__rate_interval])
160160
||| % $._config,
161161
legendFormat='{{ pod }}',
162162
),
@@ -172,7 +172,7 @@ local stackedPanelMixin = {
172172
panel.withQueries([
173173
panel.newQuery(
174174
expr= |||
175-
rate(exporter_send_failed_spans_ratio_total{%(instanceSelector)s}[$__rate_interval])
175+
rate(otelcol_exporter_send_failed_spans_total{%(instanceSelector)s}[$__rate_interval])
176176
||| % $._config,
177177
legendFormat='{{ pod }}',
178178
),

0 commit comments

Comments
 (0)