Skip to content

Commit c914038

Browse files
gr2mjimthoburn
andauthored
feat: details page styling (#44)
Co-authored-by: Jim Thoburn <[email protected]>
1 parent 675cc88 commit c914038

File tree

3 files changed

+62
-35
lines changed

3 files changed

+62
-35
lines changed

api/detail.js

Lines changed: 17 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -55,15 +55,14 @@ module.exports = async (request, response) => {
5555
endpoint.parameters
5656
)) {
5757
parameters.push(`
58-
<tr>
59-
<td>${parameterField({
58+
<dt>${parameterField({
6059
name,
6160
type,
6261
value: request.query[name] || ""
63-
})}</td>
64-
<td><code>${type}</code></td>
65-
<td>${markdown.render(description)}</td>
66-
</tr>
62+
})}</dt>
63+
<dd>
64+
${markdown.render(`\`${type}\` ` + description)}
65+
</dd>
6766
`);
6867
}
6968

@@ -137,30 +136,18 @@ module.exports = async (request, response) => {
137136
138137
<section>
139138
<h2>Parameters</h2>
140-
<form action="#request-preview" id="parametersForm">
141-
<table>
142-
<thead>
143-
<tr>
144-
<th>Name</th>
145-
<th>Type</th>
146-
<th>Description</th>
147-
</tr>
148-
</thead>
149-
<tbody>
150-
<tr>
151-
<td>
152-
<label>
153-
<code>token</code><br />
154-
<input type="text" name="token" value="${request.query
155-
.token || ""}" />
156-
</label>
157-
</td>
158-
<td><code>string</code></td>
159-
<td><p>The token will be passed in the authorization header.</p></td>
160-
</tr>
161-
${parameters.join("")}
162-
</tbody>
163-
</table>
139+
<form action="#request-preview" id="parametersForm" class="parameters">
140+
<dl>
141+
<dt>
142+
<label>
143+
<span>token</span>
144+
<input type="text" name="token" value="${request.query
145+
.token || ""}" />
146+
</label>
147+
</dt>
148+
<dd><p><code>string</code> The token will be passed in the authorization header.</p></dd>
149+
${parameters.join("")}
150+
</dl>
164151
<p><button type="submit">Update request preview</button></p>
165152
</form>
166153

public/components/parameter-field.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ function radioFieldSet({ name, options, selectedValue }) {
77
<input type="radio" name="${name}" value="${option}" ${
88
selectedValue === option ? `checked` : ""
99
} />
10-
<code>${option}</code>
10+
<span>${option}</span>
1111
</label>
1212
</li>
1313
`);
@@ -29,7 +29,7 @@ function parameterField({ name, type, value }) {
2929
if (type === "integer") {
3030
return `
3131
<label>
32-
<code>${name}</code><br />
32+
<span>${name}</span>
3333
<input type="number" name="${name}" value="${value}" />
3434
</label>
3535
`;
@@ -44,7 +44,7 @@ function parameterField({ name, type, value }) {
4444
// Text field (Default)
4545
return `
4646
<label>
47-
<code>${name}</code><br />
47+
<span>${name}</span>
4848
<input type="text" name="${name}" value="${value}" />
4949
</label>
5050
`;

public/style.css

Lines changed: 42 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ th {
104104
font-weight: 700;
105105
}
106106
tbody {
107-
vertical-align: middle;
107+
vertical-align: top;
108108
border-color: inherit;
109109
}
110110
tr {
@@ -180,5 +180,45 @@ form h1 {
180180
.details > * {
181181
margin: 3rem auto;
182182
padding: 1.5rem;
183-
max-width: 45rem;
183+
/* max-width: 45rem; */
184+
}
185+
186+
/* Parameters */
187+
.parameters input {
188+
width: 10em;
189+
display: block;
190+
margin: 0;
191+
}
192+
.parameters dt,
193+
.parameters dd {
194+
border: none;
195+
padding: 1em 0;
196+
}
197+
.parameters dt {
198+
border-top: 1px solid hsl(0, 0%, 80%);
199+
}
200+
.parameters dd {
201+
margin-left: 0;
202+
}
203+
204+
.parameters dd p {
205+
margin: 0;
206+
}
207+
208+
@media (min-width: 60em) {
209+
.parameters dl {
210+
display: grid;
211+
grid-template-columns: max-content auto;
212+
}
213+
.parameters label {
214+
display: flex;
215+
align-items: center;
216+
}
217+
.parameters label span {
218+
min-width: 7em;
219+
}
220+
.parameters dd {
221+
border-top: 1px solid hsl(0, 0%, 80%);
222+
padding-left: 2em;
223+
}
184224
}

0 commit comments

Comments
 (0)