Skip to content

glyphsLib crash on master custom parameter Axes: GSFontMaster has no _set_axes_from_custom_parameter #1122

@stepwise-alan

Description

@stepwise-alan

Environment

  • glyphsLib 6.12.6
  • fontmake 3.11.1
  • macOS

Steps

  1. Save the following as glyphslib_axes_master_bug.glyphs
  2. Run:
    python3 -m fontmake -g glyphslib_axes_master_bug.glyphs -o ttf --output-dir build/repro

Observed

Loading Glyphs file failed: 'GSFontMaster' object has no attribute '_set_axes_from_custom_parameter'

Expected

Should parse/ignore master-level custom parameter Axes without crashing.

Repro file content:

{
.appVersion = "3425";
.formatVersion = 3;
axes = (
{
name = Weight;
tag = wght;
}
);
familyName = "AxesMasterRepro";
fontMaster = (
{
axesValues = (
100
);
customParameters = (
{
name = Axes;
value = (
{
Name = Weight;
Tag = wght;
}
);
}
);
id = "MASTER_1";
name = Regular;
}
);
glyphs = (
{
glyphname = A;
layers = (
{
layerId = "MASTER_1";
shapes = (
{
closed = 1;
nodes = (
(100,0,l),
(500,0,l),
(300,700,l)
);
}
);
width = 600;
}
);
unicode = 65;
}
);
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions