From 8a310269310897428ddf4b3b9504b7fa1b4904eb Mon Sep 17 00:00:00 2001 From: Lawrence Qiu Date: Thu, 26 Jun 2025 14:45:11 -0400 Subject: [PATCH 1/4] chore: Test with Protobuf-Java v4.29.4 --- .kokoro/build.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/.kokoro/build.sh b/.kokoro/build.sh index 7c267d2a6..f2e90693d 100755 --- a/.kokoro/build.sh +++ b/.kokoro/build.sh @@ -63,6 +63,7 @@ javadoc) integration) mvn -B ${INTEGRATION_TEST_ARGS} \ -ntp \ + -Dprotobuf.version=4.29.4 \ -Penable-integration-tests \ -DtrimStackTrace=false \ -Dclirr.skip=true \ From 891932f25018ee34ab720b3822adbe4146a7fa98 Mon Sep 17 00:00:00 2001 From: cloud-java-bot Date: Thu, 26 Jun 2025 18:48:40 +0000 Subject: [PATCH 2/4] chore: generate libraries at Thu Jun 26 18:46:45 UTC 2025 --- .kokoro/build.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/.kokoro/build.sh b/.kokoro/build.sh index f2e90693d..7c267d2a6 100755 --- a/.kokoro/build.sh +++ b/.kokoro/build.sh @@ -63,7 +63,6 @@ javadoc) integration) mvn -B ${INTEGRATION_TEST_ARGS} \ -ntp \ - -Dprotobuf.version=4.29.4 \ -Penable-integration-tests \ -DtrimStackTrace=false \ -Dclirr.skip=true \ From cc7048bc105473c2d407fbb223ca4d6aed3b7a7d Mon Sep 17 00:00:00 2001 From: Lawrence Qiu Date: Thu, 26 Jun 2025 14:52:58 -0400 Subject: [PATCH 3/4] Revert "chore: generate libraries at Thu Jun 26 18:46:45 UTC 2025" This reverts commit 2eac7d63c0635aa42dfa4bb054ca5e27dfebf96a. --- .kokoro/build.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/.kokoro/build.sh b/.kokoro/build.sh index 7c267d2a6..f2e90693d 100755 --- a/.kokoro/build.sh +++ b/.kokoro/build.sh @@ -63,6 +63,7 @@ javadoc) integration) mvn -B ${INTEGRATION_TEST_ARGS} \ -ntp \ + -Dprotobuf.version=4.29.4 \ -Penable-integration-tests \ -DtrimStackTrace=false \ -Dclirr.skip=true \ From 0d6aa3cd1ef68926c78c4ce403988ba8fbb90879 Mon Sep 17 00:00:00 2001 From: Lawrence Qiu Date: Thu, 26 Jun 2025 14:53:17 -0400 Subject: [PATCH 4/4] chore: Test with Protobuf-Java v4.29.4 --- .../hermetic_library_generation.yaml | 88 +++++++++---------- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/.github/workflows/hermetic_library_generation.yaml b/.github/workflows/hermetic_library_generation.yaml index 5a97a4380..52a60ed5f 100644 --- a/.github/workflows/hermetic_library_generation.yaml +++ b/.github/workflows/hermetic_library_generation.yaml @@ -1,45 +1,45 @@ -# Copyright 2024 Google LLC +## Copyright 2024 Google LLC +## +## Licensed under the Apache License, Version 2.0 (the "License"); +## you may not use this file except in compliance with the License. +## You may obtain a copy of the License at +## +## http://www.apache.org/licenses/LICENSE-2.0 +## +## Unless required by applicable law or agreed to in writing, software +## distributed under the License is distributed on an "AS IS" BASIS, +## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +## See the License for the specific language governing permissions and +## limitations under the License. +## GitHub action job to test core java library features on +## downstream client libraries before they are released. +#name: Hermetic library generation upon generation config change through pull requests +#on: +# pull_request: # -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -# GitHub action job to test core java library features on -# downstream client libraries before they are released. -name: Hermetic library generation upon generation config change through pull requests -on: - pull_request: - -env: - REPO_FULL_NAME: ${{ github.event.pull_request.head.repo.full_name }} - GITHUB_REPOSITORY: ${{ github.repository }} -jobs: - library_generation: - runs-on: ubuntu-latest - steps: - - name: Determine whether the pull request comes from a fork - run: | - if [[ "${GITHUB_REPOSITORY}" != "${REPO_FULL_NAME}" ]]; then - echo "This PR comes from a fork. Skip library generation." - echo "SHOULD_RUN=false" >> $GITHUB_ENV - else - echo "SHOULD_RUN=true" >> $GITHUB_ENV - fi - - uses: actions/checkout@v4 - if: env.SHOULD_RUN == 'true' - with: - fetch-depth: 0 - token: ${{ secrets.CLOUD_JAVA_BOT_TOKEN }} - - uses: googleapis/sdk-platform-java/.github/scripts@v2.61.0 - if: env.SHOULD_RUN == 'true' - with: - base_ref: ${{ github.base_ref }} - head_ref: ${{ github.head_ref }} - token: ${{ secrets.CLOUD_JAVA_BOT_TOKEN }} +#env: +# REPO_FULL_NAME: ${{ github.event.pull_request.head.repo.full_name }} +# GITHUB_REPOSITORY: ${{ github.repository }} +#jobs: +# library_generation: +# runs-on: ubuntu-latest +# steps: +# - name: Determine whether the pull request comes from a fork +# run: | +# if [[ "${GITHUB_REPOSITORY}" != "${REPO_FULL_NAME}" ]]; then +# echo "This PR comes from a fork. Skip library generation." +# echo "SHOULD_RUN=false" >> $GITHUB_ENV +# else +# echo "SHOULD_RUN=true" >> $GITHUB_ENV +# fi +# - uses: actions/checkout@v4 +# if: env.SHOULD_RUN == 'true' +# with: +# fetch-depth: 0 +# token: ${{ secrets.CLOUD_JAVA_BOT_TOKEN }} +# - uses: googleapis/sdk-platform-java/.github/scripts@v2.60.0 +# if: env.SHOULD_RUN == 'true' +# with: +# base_ref: ${{ github.base_ref }} +# head_ref: ${{ github.head_ref }} +# token: ${{ secrets.CLOUD_JAVA_BOT_TOKEN }}