feat(gax): add ResumableUploadClient and types for startUpload() - #14072
Closed
whowes wants to merge 1 commit into
Closed
feat(gax): add ResumableUploadClient and types for startUpload()#14072whowes wants to merge 1 commit into
whowes wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
whowes
force-pushed
the
whowes/resumable-upload-client
branch
2 times, most recently
from
August 13, 2026 22:38
24d585f to
1ee141c
Compare
Contributor
Author
|
/gemini review |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
whowes
changed the title
whowes
force-pushed
the
whowes/resumable-upload-client
branch
from
August 14, 2026 00:28
1ee141c to
8bf9f95
Compare
whowes
changed the title
whowes
force-pushed
the
whowes/resumable-upload-client
branch
2 times, most recently
from
August 14, 2026 01:14
1dd6b86 to
b8e7261
Compare
whowes
marked this pull request as ready for review
August 14, 2026 01:54
whowes
marked this pull request as draft
August 14, 2026 16:05
whowes
force-pushed
the
whowes/resumable-upload-client
branch
from
August 17, 2026 23:44
b8e7261 to
003083c
Compare
whowes
changed the base branch from
main
to
whowes/string-http-response-parser
August 17, 2026 23:44
whowes
force-pushed
the
whowes/resumable-upload-client
branch
2 times, most recently
from
August 18, 2026 00:03
34d9c14 to
68cadaf
Compare
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the initial API types and interfaces for low-level resumable upload operations under the com.google.api.gax.resumable package. It adds the ResumableUploadClient interface, the ResumableUploadSession and StartUploadRequest AutoValue classes, and corresponding unit tests to verify immutability, path normalization, and chunk granularity defaults. I have no feedback to provide.
whowes
force-pushed
the
whowes/resumable-upload-client
branch
from
August 18, 2026 00:35
68cadaf to
c07069b
Compare
whowes
added
the
kokoro:force-run
whowes
force-pushed
the
whowes/resumable-upload-client
branch
from
August 18, 2026 21:51
c07069b to
8a4d18e
Compare
whowes
force-pushed
the
whowes/string-http-response-parser
branch
from
August 18, 2026 21:51
a2f2378 to
35f7e29
Compare
whowes
changed the base branch from
whowes/string-http-response-parser
to
whowes/get-first-header
August 18, 2026 21:53
whowes
changed the title
whowes
force-pushed
the
whowes/resumable-upload-client
branch
from
August 18, 2026 22:52
8a4d18e to
8ca4f84
Compare
whowes
force-pushed
the
whowes/get-first-header
branch
from
August 18, 2026 22:52
0dbf15c to
3a364dd
Compare
whowes
force-pushed
the
whowes/resumable-upload-client
branch
from
August 18, 2026 23:39
8ca4f84 to
4030840
Compare
whowes
force-pushed
the
whowes/get-first-header
branch
2 times, most recently
from
August 19, 2026 15:59
4295797 to
4616b5f
Compare
whowes
force-pushed
the
whowes/resumable-upload-client
branch
2 times, most recently
from
August 19, 2026 16:22
087c159 to
5a27f29
Compare
whowes
force-pushed
the
whowes/get-first-header
branch
from
August 19, 2026 16:22
4616b5f to
3a75d9c
Compare
whowes
force-pushed
the
whowes/resumable-upload-client
branch
from
August 19, 2026 17:15
5a27f29 to
8765335
Compare
whowes
force-pushed
the
whowes/get-first-header
branch
from
August 19, 2026 17:15
3a75d9c to
6f625b3
Compare
whowes
changed the base branch from
whowes/get-first-header
to
whowes/new-exception-constructor
August 19, 2026 17:17
whowes
force-pushed
the
whowes/new-exception-constructor
branch
from
August 19, 2026 18:24
7f5be2e to
57247e9
Compare
whowes
force-pushed
the
whowes/resumable-upload-client
branch
from
August 19, 2026 18:24
8765335 to
202c82a
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP/JSON client implementation for startUpload is in #14091.