Skip to content

Commit c9a52a5

Browse files
committed
no-mistakes(lint): Format and lint fixes
1 parent ecdfe1f commit c9a52a5

3 files changed

Lines changed: 8 additions & 6 deletions

File tree

java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/BuiltInMetricsConstant.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import com.google.common.collect.ImmutableSet;
2626
import io.opentelemetry.api.common.AttributeKey;
2727
import io.opentelemetry.sdk.metrics.Aggregation;
28+
import io.opentelemetry.sdk.metrics.ExplicitBucketHistogramOptions;
2829
import io.opentelemetry.sdk.metrics.InstrumentSelector;
2930
import io.opentelemetry.sdk.metrics.InstrumentType;
3031
import io.opentelemetry.sdk.metrics.View;
@@ -215,7 +216,8 @@ public class BuiltInMetricsConstant {
215216
200.0, 250.0, 300.0, 400.0, 500.0, 650.0, 800.0, 1000.0, 2000.0, 5000.0, 10000.0, 20000.0,
216217
50000.0, 100000.0, 200000.0, 400000.0, 800000.0, 1600000.0, 3200000.0);
217218
static Aggregation AGGREGATION_WITH_MILLIS_HISTOGRAM =
218-
Aggregation.explicitBucketHistogram(BUCKET_BOUNDARIES);
219+
Aggregation.explicitBucketHistogram(
220+
ExplicitBucketHistogramOptions.builder().setBucketBoundaries(BUCKET_BOUNDARIES).build());
219221

220222
static final Collection<String> GRPC_METRICS_ENABLED_BY_DEFAULT =
221223
ImmutableList.of(

java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/MetricsProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
* <li>{@link DefaultMetricsProvider}: No caller-owned client-metrics destination is configured.
3030
* This is the default. On {@link SpannerOptions.InstanceType#OMNI}, where the Cloud
3131
* Monitoring export is not available, this means no client metrics are exported.
32-
* <li>{@link NoopMetricsProvider}: Caller-owned client metrics are explicitly disabled. The
33-
* Cloud Monitoring export is controlled separately.
32+
* <li>{@link NoopMetricsProvider}: Caller-owned client metrics are explicitly disabled. The Cloud
33+
* Monitoring export is controlled separately.
3434
* <li>{@link CustomOpenTelemetryMetricsProvider}: The same Spanner client instruments are
3535
* recorded on a caller-provided {@link io.opentelemetry.api.OpenTelemetry} instance.
3636
* </ul>

java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2221,9 +2221,9 @@ public Builder setBuiltInMetricsEnabled(boolean enableBuiltInMetrics) {
22212221
/**
22222222
* Sets the {@link MetricsProvider} that controls client-metrics export to a caller-owned
22232223
* OpenTelemetry destination. Defaults to {@link DefaultMetricsProvider#INSTANCE}, which does
2224-
* not configure a caller-owned destination. Use {@link NoopMetricsProvider#INSTANCE} to
2225-
* disable caller-owned client metrics explicitly, or {@link CustomOpenTelemetryMetricsProvider}
2226-
* to record the same Spanner client instruments on a caller-provided {@link OpenTelemetry}
2224+
* not configure a caller-owned destination. Use {@link NoopMetricsProvider#INSTANCE} to disable
2225+
* caller-owned client metrics explicitly, or {@link CustomOpenTelemetryMetricsProvider} to
2226+
* record the same Spanner client instruments on a caller-provided {@link OpenTelemetry}
22272227
* instance.
22282228
*
22292229
* <p>Client metrics are independent of the built-in Cloud Monitoring (GCM) export controlled by

0 commit comments

Comments
 (0)