Skip to content

Commit a6081bc

Browse files
committed
rm unnecessary issue creation and make this presubmit
1 parent 97cd5f2 commit a6081bc

1 file changed

Lines changed: 2 additions & 16 deletions

File tree

.github/workflows/formatter-version-check.yaml

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ permissions:
1818
name: Librarian - Formatter Version Check
1919

2020
on:
21-
schedule:
22-
- cron: '30 3 * * *' # Run daily at 3:30 AM UTC
2321
workflow_dispatch: # Allow manual trigger
2422
pull_request:
2523

@@ -43,11 +41,8 @@ jobs:
4341
4442
check-formatter-version:
4543
needs: filter
46-
if: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || needs.filter.outputs.should_run == 'true' }}
44+
if: ${{ github.event_name == 'workflow_dispatch' || needs.filter.outputs.should_run == 'true' }}
4745
runs-on: ubuntu-latest
48-
permissions:
49-
contents: read
50-
issues: write
5146
steps:
5247
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
5348
with:
@@ -86,19 +81,10 @@ jobs:
8681
8782
if [ "${POM_VERSION}" != "${LIBRARIAN_VERSION}" ]; then
8883
echo "Mismatch: librarian.yaml has version '${LIBRARIAN_VERSION}', but java-shared-config/java-shared-config/pom.xml has version '${POM_VERSION}'"
89-
exit 2
84+
exit 1
9085
fi
9186
9287
echo "Formatter versions are in sync!"
9388
env:
9489
POM_VERSION: ${{ steps.extract_pom_version.outputs.version }}
9590
LIBRARIAN_VERSION: ${{ steps.extract_librarian_version.outputs.version }}
96-
- name: Create issue on failure
97-
if: ${{ failure() && github.event_name == 'schedule' }}
98-
uses: googleapis/librarian/.github/actions/create-issue-on-failure@35997441eafc2b02716804f9baba1e3f04f8a44f # v0.31.1
99-
with:
100-
title: "Formatter Version Mismatch: librarian.yaml and java-shared-config pom.xml out of sync"
101-
body: |
102-
The google-java-format version in `java-shared-config/java-shared-config/pom.xml` and `librarian.yaml` do not match. Please update them to match.
103-
104-
Please check the logs: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}

0 commit comments

Comments
 (0)