Commit 5b8e295
authored
fix: fix java-cloud-bom README update workflow after monorepo migration (#13892)
Fixes b/537369259
### Context
After the monorepo migration (PR #13498), the `java-cloud-bom`
repository was moved into the `java-cloud-bom/` subdirectory. The GitHub
Actions workflow
`.github/workflows/java-cloud-bom-update-readme-table.yaml` was copied
over from the split repository without updating its paths or filter
triggers.
### Root Causes
1. **Path-Filter Always Skips on Release Events:** On a `release` event,
`dorny/paths-filter` compares the release tag commit against `main`.
Since release commits are already merged to `main` prior to tagging, the
diff is empty, causing `dorny/paths-filter` to evaluate to `false` and
skip the `update-readme` job.
2. **Missing Working Directory:** The workflow attempted to run `python
libraries-bom-table-generation/updateREADMETable.py` from the repository
root, but both the script and target `README.md` are located within the
`java-cloud-bom/` subdirectory.
### Fix
- **Removed redundant `filter` job:** Replaced it with a direct job
condition:
```yaml
if: ${{ github.event_name == 'workflow_dispatch' ||
startsWith(github.event.release.tag_name, 'libraries-bom/') }}
```
This matches the release tag pattern (`libraries-bom/v*`) used by
`create_additional_release_tag.yaml` and
`java-cloud-bom-release-note-generation.yaml`.
- **Configured Working Directory:** Added
`defaults.run.working-directory: java-cloud-bom` to the `update-readme`
job so all steps execute inside `java-cloud-bom/`.1 parent d586d07 commit 5b8e295
1 file changed
Lines changed: 7 additions & 18 deletions
Lines changed: 7 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | 16 | | |
31 | | - | |
32 | | - | |
| 17 | + | |
33 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
34 | 22 | | |
35 | 23 | | |
36 | 24 | | |
37 | 25 | | |
38 | 26 | | |
39 | | - | |
| 27 | + | |
40 | 28 | | |
41 | | - | |
| 29 | + | |
| 30 | + | |
42 | 31 | | |
43 | 32 | | |
44 | 33 | | |
| |||
0 commit comments