Skip to content

Commit 2f79b14

Browse files
committed
build: explicitly map shade.skip in shaded module configurations
Maven Shade Plugin's skip parameter does not declare a built-in property expression in its Mojo descriptor, so explicit mapping via <skip>${shade.skip}</skip> is required for the profile property to take effect.
1 parent 963a2f8 commit 2f79b14

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

java-spanner-jdbc/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,7 @@
275275
<goal>shade</goal>
276276
</goals>
277277
<configuration>
278+
<skip>${shade.skip}</skip>
278279
<createSourcesJar>true</createSourcesJar>
279280
<shadeSourcesContent>true</shadeSourcesContent>
280281
<shadedArtifactAttached>true</shadedArtifactAttached>

sdk-platform-java/gapic-generator-java/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,7 @@
255255
<goal>shade</goal>
256256
</goals>
257257
<configuration>
258+
<skip>${shade.skip}</skip>
258259
<createDependencyReducedPom>false</createDependencyReducedPom>
259260
<filters>
260261
<filter>

0 commit comments

Comments
 (0)