From 3105699046c6a7dc5c1ff2613633f26915b3030f Mon Sep 17 00:00:00 2001 From: Pushp Agarwal Date: Fri, 18 Jul 2025 08:11:53 +0530 Subject: [PATCH 1/2] Fix type definition mismatch for emscripten bindings The current type definitions don't match the actual implementation where value objects and emscripten::val types are handled differently by the binding layer. This causes wrong match for typescript client using FontStyle type. Updated type declarations to correctly reflect the emscripten binding behavior and ensure client written in ts works correctly. --- modules/canvaskit/npm_build/types/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/canvaskit/npm_build/types/index.d.ts b/modules/canvaskit/npm_build/types/index.d.ts index 39a8995ded6b..bb2d5d3a00e4 100644 --- a/modules/canvaskit/npm_build/types/index.d.ts +++ b/modules/canvaskit/npm_build/types/index.d.ts @@ -2095,7 +2095,7 @@ export interface FontMgr extends EmbindObject<"FontMgr"> { /** * Find the closest matching typeface to the specified familyName and style. */ - matchFamilyStyle(name: string, style: FontStyle): Typeface; + matchFamilyStyle(name: string, style: {width?: number, weight?: number, slant?: number}): Typeface; } /** From e1ea6af117e2afde43f8046c90f21433d91875b9 Mon Sep 17 00:00:00 2001 From: Pushp Agarwal Date: Sat, 19 Jul 2025 10:04:06 +0530 Subject: [PATCH 2/2] Adding my name to AUTHORS file. --- AUTHORS | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS b/AUTHORS index 979766465b67..5e1cbc5cdb9c 100644 --- a/AUTHORS +++ b/AUTHORS @@ -84,6 +84,7 @@ Opera Software ASA <*@opera.com> Pavel Krajcevski Petar Kirov Ping Wang +Pushp Parag Agarwal Raul Tambre Roman Petrenko Safa Sofuoglu