Skip to content

WIP scan #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
umeshkumhar wants to merge 7 commits into
base: v0.3.2
Choose a base branch
from
Open

WIP scan #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d098b6b
Update golang-ci.yml
umeshkumhar Oct 17, 2022
5600251
Update shifter.go
umeshkumhar Oct 17, 2022
daddf17
Update golang-ci.yml
umeshkumhar Oct 17, 2022
0992131
Update helm.go
umeshkumhar Oct 17, 2022
743cc7a
Update shifter.go
umeshkumhar Oct 17, 2022
647a048
Update golang-ci.yml
umeshkumhar Nov 18, 2022
645bdcd
Update golang-ci.yml
umeshkumhar Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions .github/workflows/golang-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Github Actions - Golang
name: Github Actions - Shifter
on:
pull_request:
paths:
Expand All @@ -12,7 +12,7 @@ defaults:
working-directory: ./shifter

jobs:
golang-ci-workflow:
shifter-ci-workflow:
runs-on: ubuntu-latest
steps:
- uses: actions/setup-go@v3
Expand All @@ -33,7 +33,19 @@ jobs:
with:
sarif_file: results.sarif
- name: Run Build
run: make build
run: make build
- name: Run Trivy vulnerability scanner
uses: aquasecurity/trivy-action@master
with:
image-ref: 'us-docker.pkg.dev/shifter-lz-002/dev-shifter/${{ github.head_ref || github.ref_name }}/shifter'
format: 'sarif'
output: 'trivy-results.sarif'

- name: Upload Trivy scan results to GitHub Security tab
uses: github/codeql-action/upload-sarif@v2
if: always()
with:
sarif_file: 'trivy-results.sarif'


# ## we can update once we have unit testcases inplace
Expand Down
2 changes: 1 addition & 1 deletion shifter/generator/helm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import (

"gopkg.in/yaml.v3"
json "k8s.io/apimachinery/pkg/runtime/serializer/json"
//"strconv"
// "strconv"
)

type Chart struct {
Expand Down