-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Open
Labels
Description
If an input file name contains non-7bit-ASCII characters in it, Closure fails to operate.
STR:
- Install Closure compiler to directory "☃äö Ć € 🦠". (not mandatory, but for good measure to see if any issues arise from that)
- Pass an input file "☃äö Ć € 🦠.js" to Closure compiler as
--externs
or--js
.
Results in
C:\☃em sd äö Ć € 🦠\emsdk\emscripten\main> dir äö.js
Volume in drive C has no label.
Volume Serial Number is 8847-8E7D
Directory of C:\☃em sd äö Ć € 🦠\emsdk\emscripten\main
03/16/2021 06:18 PM 3,472 äö.js
1 File(s) 3,472 bytes
0 Dir(s) 1,757,394,030,592 bytes free
C:\☃em sd äö Ć € 🦠\emsdk\emscripten\main> node_modules\.bin\google-closure-compiler --externs äö.js --js_output_file out.js --js a.js
[ '--externs', 'äö.js', '--js_output_file', 'out.js', '--js', 'a.js' ]
ERROR - [JSC_READ_ERROR] Cannot read file äö.js: äö.js
1 error(s), 0 warning(s)
C:\☃em sd äö Ć € 🦠\emsdk\emscripten\main> node_modules\.bin\google-closure-compiler --externs a.js --js_output_file out.js --js äö.js
[ '--externs', 'a.js', '--js_output_file', 'out.js', '--js', 'äö.js' ]
ERROR - [JSC_READ_ERROR] Cannot read file äö.js: äö.js
1 error(s), 0 warning(s)
- Pass UTF-8 chars as output file :
C:\☃em sd äö Ć € 🦠\emsdk\emscripten\main> node_modules\.bin\google-closure-compiler --js a.js --js_output_file äää.js
[ '--js', 'a.js', '--js_output_file', 'äää.js' ]
C:\☃em sd äö Ć € 🦠\emsdk\emscripten\main> dir *.js
Volume in drive C has no label.
Volume Serial Number is 8847-8E7D
Directory of C:\☃em sd äö Ć € 🦠\emsdk\emscripten\main
03/16/2021 06:18 PM 3,472 a.js
03/16/2021 06:24 PM 5,595 äää.js
2 File(s) 9,067 bytes
0 Dir(s) 1,757,393,338,368 bytes free
Ilya-Zhulin
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
juj commentedon Mar 16, 2021
(The
[ '--externs', 'äö.js', '--js_output_file', 'out.js', '--js', 'a.js' ]
print is one of my own added debug prints, trying to look if the proper path names even reach Closure, which they seem to do. Also did the test prints with simpleräö.js
filename to verify the extent of the failure to do UTF-8 handling)Work around Closure compiler issue google/closure-compiler#3784 that …
Work around Closure compiler issue google/closure-compiler#3784 that …
Work around Closure compiler issue with unicode characters (#13680)
sbc100 commentedon Aug 24, 2021
Any chance we could get a fix for this? The current workaround in emscripten is kind of horrible.
Only rename closure inputs if needed
Only rename closure inputs if needed
Only rename closure inputs if needed
Only rename closure inputs if needed (#14937)
Chris2011 commentedon Oct 10, 2021
Is this related to this error, that I get for a file with a cyrillic filename?
Filename:
наиывпишв.js
And here is my command:
"C:\Users\Chris\.netbeans\minifierbeans\custom-packages\google-closure-compiler.cmd" "--compilation_level" "SIMPLE" "--language_in" "STABLE" "--language_out" "ECMASCRIPT_NEXT" "--js" "C:/Users/Chris/Documents/NetBeansProjects/HTML5Application/public_html/наиывпишв.js" "--js_output_file" "C:/Users/Chris/Documents/NetBeansProjects/HTML5Application/public_html/наиывпишв.min.js"
And here is the error:
Happens in my NetBeans plugin Chris2011/minifierbeans#90
Chris2011 commentedon Jan 4, 2022
Anything new here? Still a problem in version "20211201.0.0".
brad4d commentedon Jan 12, 2022
I'm afraid we're just really not motivated to spend development effort on making non-ascii JS inputs work.
However, we'll be happy to review and merge a PR if someone in the community would like to create one.