From f943cb359f36444f43b8e3dc34633c532c7d9cf0 Mon Sep 17 00:00:00 2001 From: Peace-Maker Date: Sat, 31 May 2025 10:01:27 +0200 Subject: [PATCH 1/4] Bump Actions versions Bump upload-artifact to v4 for the cmake workflow since v3 was deprecated and disabled. --- .github/workflows/cmake.yml | 4 ++-- .github/workflows/gradle.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml index 4dd85868..80724d54 100644 --- a/.github/workflows/cmake.yml +++ b/.github/workflows/cmake.yml @@ -35,7 +35,7 @@ jobs: - name: Enable Developer Command Prompt (Windows) if: matrix.os == 'windows-2022' - uses: ilammy/msvc-dev-cmd@v1.12.1 + uses: ilammy/msvc-dev-cmd@v1.13.0 - name: Enable mold linker (Linux) if: matrix.os == 'ubuntu-22.04' @@ -60,7 +60,7 @@ jobs: run: ctest --build-config "${BUILD_TYPE}" --output-on-failure -R '^[A-Z]' - name: Upload Build Artifacts - uses: actions/upload-artifact@v3.1.2 + uses: actions/upload-artifact@v4 with: name: BinExport-${{ runner.os }} path: | diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml index c0968466..8b11363a 100644 --- a/.github/workflows/gradle.yml +++ b/.github/workflows/gradle.yml @@ -30,12 +30,12 @@ jobs: java-version: "21" - name: Setup Ghidra - uses: antoniovazquezblanco/setup-ghidra@v2.0.3 + uses: antoniovazquezblanco/setup-ghidra@v2.0.12 with: version: ${{ matrix.ghidra }} - name: Setup Gradle - uses: gradle/actions/setup-gradle@v3 + uses: gradle/actions/setup-gradle@v4 with: gradle-version: 8.7 From fb8e25a6878f55ba971f502d8417e2afd16d28ec Mon Sep 17 00:00:00 2001 From: Peace-Maker Date: Sat, 31 May 2025 10:02:47 +0200 Subject: [PATCH 2/4] Switch to `macos-13` image The macos-12 image was removed on 12/3/24. --- .github/workflows/cmake.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml index 80724d54..75e22ae5 100644 --- a/.github/workflows/cmake.yml +++ b/.github/workflows/cmake.yml @@ -12,7 +12,7 @@ jobs: matrix: include: - os: ubuntu-22.04 - - os: macos-12 + - os: macos-13 - os: windows-2022 runs-on: ${{ matrix.os }} From 5288cff86daeefa89a90275fa97bbc5162ad827c Mon Sep 17 00:00:00 2001 From: Peace-Maker Date: Sat, 31 May 2025 10:05:30 +0200 Subject: [PATCH 3/4] Fix typo accessing runner.workspace The `runner` object isn't documented to have a `workspace` member. Switch to using the documented `github.workspace` variable. https://docs.github.com/de/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#runner-context --- .github/workflows/cmake.yml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml index 75e22ae5..b23d9165 100644 --- a/.github/workflows/cmake.yml +++ b/.github/workflows/cmake.yml @@ -28,10 +28,10 @@ jobs: working-directory: ${{ github.workspace }} shell: bash run: | - mkdir -p "${{ runner.workspace }}/build" + mkdir -p "${{ github.workspace }}/build" ./.github/scripts/decrypt_secret.sh - unzip -q "${{ runner.workspace }}/build/idasdk_teams82.zip" \ - -d "${{ runner.workspace }}/build/" + unzip -q "${{ github.workspace }}/build/idasdk_teams82.zip" \ + -d "${{ github.workspace }}/build/" - name: Enable Developer Command Prompt (Windows) if: matrix.os == 'windows-2022' @@ -42,20 +42,20 @@ jobs: uses: rui314/setup-mold@v1 - name: Configure CMake - working-directory: ${{ runner.workspace }}/build + working-directory: ${{ github.workspace }}/build shell: bash run: | cmake "${{ github.workspace }}" -G Ninja \ "-DCMAKE_BUILD_TYPE=${BUILD_TYPE}" \ - "-DIdaSdk_ROOT_DIR=${{ runner.workspace }}/build/idasdk_teams82" + "-DIdaSdk_ROOT_DIR=${{ github.workspace }}/build/idasdk_teams82" - name: Build - working-directory: ${{ runner.workspace }}/build + working-directory: ${{ github.workspace }}/build shell: bash run: cmake --build . --config "${BUILD_TYPE}" - name: Test - working-directory: ${{ runner.workspace }}/build + working-directory: ${{ github.workspace }}/build shell: bash run: ctest --build-config "${BUILD_TYPE}" --output-on-failure -R '^[A-Z]' @@ -64,6 +64,6 @@ jobs: with: name: BinExport-${{ runner.os }} path: | - ${{ runner.workspace }}/build/binaryninja/binexport* - ${{ runner.workspace }}/build/ida/binexport* - ${{ runner.workspace }}/build/tools/binexport2dump* + ${{ github.workspace }}/build/binaryninja/binexport* + ${{ github.workspace }}/build/ida/binexport* + ${{ github.workspace }}/build/tools/binexport2dump* From dc8bf11629c0e3ceca595161ccd0a0cf35efaf69 Mon Sep 17 00:00:00 2001 From: Peace-Maker Date: Sat, 31 May 2025 10:10:45 +0200 Subject: [PATCH 4/4] Build Ghidra plugin for newer Ghidra versions too --- .github/workflows/gradle.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml index 8b11363a..9ba910a4 100644 --- a/.github/workflows/gradle.yml +++ b/.github/workflows/gradle.yml @@ -17,7 +17,7 @@ jobs: strategy: fail-fast: false matrix: - ghidra: ${{ fromJSON(format('[{0}]', inputs.ghidra_version || '"latest","11.1.2","11.1.1","11.1","11.0.3","11.0.2","11.0.1","11.0"')) }} + ghidra: ${{ fromJSON(format('[{0}]', inputs.ghidra_version || '"latest","11.3.2","11.3.1","11.3","11.2.1","11.2","11.1.2","11.1.1","11.1","11.0.3","11.0.2","11.0.1","11.0"')) }} runs-on: ubuntu-22.04 steps: