update to use binaryninja-api generate stubs

Author: colinmkinsella

.github/workflows/cmake.yml

@@ -12,15 +12,28 @@ jobs:
       matrix:
         include:
         - os: ubuntu-22.04
-        - os: macos-12
+          boost_platform_version: 22.04
+          boost_toolset: gcc
+          boost_arch: x86
+        - os: macos-13
+          boost_platform_version: 13
+          boost_toolset: clang
+          boost_arch: x86
+        - os: macos-14
+          boost_platform_version: 14
+          boost_toolset: clang
+          boost_arch: aarch64
         - os: windows-2022
+          boost_platform_version: 2022
+          boost_toolset: msvc
+          boost_arch: x86
     runs-on: ${{ matrix.os }}
 
     steps:
     - uses: actions/checkout@v4
 
     - name: Install ninja-build tool
-      uses: turtlesec-no/get-ninja@1.1.0
+      uses: seanmiddleditch/gha-setup-ninja@v6
 
     - name: Create Build Environment
       env:
@@ -37,6 +50,15 @@ jobs:
       if: matrix.os == 'windows-2022'
       uses: ilammy/[email protected]
 
+    - name: Install Boost
+      uses: MarkusJx/install-boost@v2
+      id: install-boost
+      with:
+        arch: ${{ matrix.boost_arch }}
+        boost_version: 1.83.0
+        platform_version: ${{ matrix.boost_platform_version }}
+        toolset: ${{ matrix.boost_toolset }}
+
     - name: Enable mold linker (Linux)
       if: matrix.os == 'ubuntu-22.04'
       uses: rui314/setup-mold@v1
@@ -47,7 +69,12 @@ jobs:
       run: |
         cmake "${{ github.workspace }}" -G Ninja \
           "-DCMAKE_BUILD_TYPE=${BUILD_TYPE}" \
-          "-DIdaSdk_ROOT_DIR=${{ runner.workspace }}/build/idasdk_teams82"
+          "-DIdaSdk_ROOT_DIR=${{ runner.workspace }}/build/idasdk_teams82" \
+          "-DBINEXPORT_ENABLE_BINARYNINJA=ON" \
+          "-DBINEXPORT_BINARYNINJA_CHANNEL=stable" \
+          "-DBoost_INCLUDE_DIR=${{steps.install-boost.outputs.BOOST_ROOT}}/include"
+      env:
+          BOOST_ROOT: ${{steps.install-boost.outputs.BOOST_ROOT}}
 
     - name: Build
       working-directory: ${{ runner.workspace }}/build
@@ -60,9 +87,9 @@ jobs:
       run: ctest --build-config "${BUILD_TYPE}" --output-on-failure -R '^[A-Z]'
 
     - name: Upload Build Artifacts
-      uses: actions/upload-artifact@v3.1.2
+      uses: actions/upload-artifact@v4
       with:
-        name: BinExport-${{ runner.os }}
+        name: BinExport-${{ runner.os }}-${{ runner.arch }}
         path: |
           ${{ runner.workspace }}/build/binaryninja/binexport*
           ${{ runner.workspace }}/build/ida/binexport*

README.md

@@ -283,6 +283,12 @@ mv third_party/idasdk/idasdk_pro82/* third_party/idasdk
 rmdir third_party/idasdk/idasdk_pro82
 ```
 
+#### Binary Ninja
+
+If building the Binary Ninja plugin, set `-DBINEXPORT_BINARYNINJA_CHANNEL` to either `stable` or `dev` to build against pinned versions of those channels.
+
+`-DBINEXPORT_BINARYNINJA_LATEST=ON` can be used to instead build against the latest commit from [GitHub](https://github.com/Vector35/binaryninja-api).
+
 #### Build BinExport
 
 With all prerequisites in place, configure and build BinExport and run

binaryninja/main_plugin.cc

@@ -567,18 +567,11 @@ bool Plugin::Init() {
 
 }  // namespace security::binexport
 
-extern "C" BINARYNINJAPLUGIN uint32_t CorePluginABIVersion() {
-  // Previously, BinExport worked around Binary Ninja's ABI version handling,
-  // to make sure to have it try and load the plugin unconditionally. This
-  // was done in order to be able to support both the fast moving "dev"
-  // channel as well as the stable one. The intention was for BinExport to
-  // use "mostly stable" API functions to work on both and have Binary Ninja
-  // ignore the plugin if it used functionality that was not available.
-  // However, this proved to be no longer feasible at some point with
-  // BinExport leading to crashes.
-  return BN_MINIMUM_CORE_ABI_VERSION;
-}
+extern "C"
+{
+  BN_DECLARE_CORE_ABI_VERSION
 
-extern "C" BINARYNINJAPLUGIN bool CorePluginInit() {
-  return security::binexport::Plugin::instance()->Init();
+  BINARYNINJAPLUGIN bool CorePluginInit() {
+    return security::binexport::Plugin::instance()->Init();
+  }
 }