Fix --override Flag Scope in testspeed and viewer #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fields like is_sparse affect model initialization and memory allocation. Overriding them after model creation causes inconsistencies. Added validation to throw exception when attempting to override these fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem #876
The
--overrideflag allowed overridingopt.is_sparseon mjw.Model after initialization. This field affects memory allocation during model creation, causing subtle bugs when changed afterwards.Solution
Added validation to prevent overriding fields with side effects. The
opt.is_sparsefield is now read-only on mjw.Model and will throw an exception if override is attempted.Changes
readonly_fieldsset to track fields that cannot be overriddenoverride_model()function