Skip to content

Fix an issue where the project settings for ARCore Extensions are not saved when using Unity 2021.2 or earlier #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix an issue where the project settings for ARCore Extensions are not saved when using Unity 2021.2 or earlier #130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69e7394
Use LogError instead of Exception for Unity 2021.2 or earlier
tarukosu Jul 3, 2023
7c73360
Merge branch 'master' into fix/project-settings-not-saved
tarukosu Jul 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Editor/Scripts/Internal/GeospatialCreatorHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,10 @@ public static void OnToggle(bool toggleChecked)
// disabled if they are present.
}
#else // Error state because this is an invalid version of Unity
throw new Exception("Geospatial Creator requires Unity 2021.3 or later.");
if (toggleChecked)
{
Debug.LogError("Geospatial Creator requires Unity 2021.3 or later.");
}
#endif
}

Expand Down