Skip to content

Commit 2b01e64

Browse files
szczysChrisGammell
authored andcommitted
CI: upgrade and fix firebase action; add write permissions
- upgrade the firebase action to the latest release - pin the node24 version to workaround regression in firebase-tools - add write permissions needed due to org-level change to read-only default Signed-off-by: Mike Szczys <michael.szczys@canonical.com>
1 parent 3ff7a27 commit 2b01e64

2 files changed

Lines changed: 37 additions & 10 deletions

File tree

.github/workflows/firebase-hosting-merge.yml

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@
33

44
name: Deploy to Firebase Hosting on merge
55

6+
permissions:
7+
deployments: write
8+
statuses: write
9+
checks: write
10+
611
on:
712
push:
813
branches:
@@ -13,17 +18,25 @@ jobs:
1318
runs-on: ubuntu-latest
1419
steps:
1520
- name: Checkout Repository
16-
uses: actions/checkout@v3
21+
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
22+
with:
23+
submodules: true
24+
25+
- name: Setup Node
26+
# yamllint disable-line rule:line-length
27+
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
28+
with:
29+
node-version: '24.18.0'
1730

18-
- name: Update and Build
31+
- name: Build
1932
run: |
20-
git submodule update --init
2133
cd website
22-
npm install
34+
npm ci
2335
npm run build
2436
2537
- name: Firebase Hosting
26-
uses: FirebaseExtended/action-hosting-deploy@v0
38+
# yamllint disable-line rule:line-length
39+
uses: FirebaseExtended/action-hosting-deploy@500ac625ca2dd40cbd15f7659af953801858032a # v0.11.0
2740
with:
2841
repoToken: '${{ secrets.GITHUB_TOKEN }}'
2942
firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_GOLIOTH }}'

.github/workflows/firebase-hosting-pull-request.yml

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@
33

44
name: Deploy to Firebase Hosting on PR
55

6+
permissions:
7+
deployments: write
8+
statuses: write
9+
checks: write
10+
pull-requests: write
11+
612
on:
713
pull_request:
814

@@ -12,17 +18,25 @@ jobs:
1218
runs-on: ubuntu-latest
1319
steps:
1420
- name: Checkout Repository
15-
uses: actions/checkout@v3
21+
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
22+
with:
23+
submodules: true
24+
25+
- name: Setup Node
26+
# yamllint disable-line rule:line-length
27+
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
28+
with:
29+
node-version: '24.18.0'
1630

17-
- name: Update and Build
31+
- name: Build
1832
run: |
19-
git submodule update --init
2033
cd website
21-
npm install
34+
npm ci
2235
npm run build
2336
2437
- name: Firebase Hosting
25-
uses: FirebaseExtended/action-hosting-deploy@v0
38+
# yamllint disable-line rule:line-length
39+
uses: FirebaseExtended/action-hosting-deploy@500ac625ca2dd40cbd15f7659af953801858032a # v0.11.0
2640
with:
2741
repoToken: '${{ secrets.GITHUB_TOKEN }}'
2842
firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_GOLIOTH }}'

0 commit comments

Comments
 (0)