Skip to content

cmd/go: go ignores overlay map when using coverpkg flag #73802

Open
@AdamKorcz

Description

@AdamKorcz

Go version

go1.23.4 linux/amd64

Output of go env in your module/workspace:

GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/adam/.cache/go-build'
GOENV='/home/adam/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/adam/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/adam/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/home/adam/go/pkg/mod/golang.org/[email protected]'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/home/adam/go/pkg/mod/golang.org/[email protected]/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.23.4'
GODEBUG=''
GOTELEMETRY='local'
GOTELEMETRYDIR='/home/adam/.config/go/telemetry'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/tmp/gopoc/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build4048790992=/tmp/go-build -gno-record-gcc-switches'

What did you do?

I created the following files:

/tmp/mymodule/go.mod:

module module3

go 1.23.4

/tmp/mymodule/overlay.json:

{
        "Replace": {
                "/tmp/mymodule/test/context_builder.go": "/tmp/context_builder.go"
        }
}

/tmp/mymodule/submodule1/one.go:

package submodule1

/tmp/mymodule/submodule1/one_test.go:

package submodule1

import (
        "strings"
        "testing"
        _ "module3/test"
)

func TestSomething(t *testing.T) {
        _ = strings.Repeat("abc", 2)
}

/tmp/mymodule/test/context_builder.go:

package test

import (
        "testing"
)

type StringGenerator func(n int) string

type Builder struct {
        T *testing.T
}

/tmp/context_builder.go:

package test

import (
        "testing"
)

func init() {
        panic("Here")
}

type StringGenerator func(n int) string

type Builder struct {
        T *testing.T
}

From /tmp/mymodule I then ran go test -run TestSomething ./submodule1 -coverpkg=./... -overlay=$PWD/overlay.json

What did you see happen?

ok module3/submodule1 0.005s coverage: [no statements]

What did you expect to see?

panic: Here

goroutine 1 [running]:
module3/test.init.0()
        /tmp/mymodule/test/context_builder.go:8 +0x25
FAIL    module3/submodule1      0.008s
FAIL

If I instead run go test -run TestSomething ./submodule1 -overlay=$PWD/overlay.json (without the coverpkg flag), I see this panic.

Metadata

Metadata

Assignees

No one assigned

    Labels

    GoCommandcmd/goNeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions