Fix decode hooks with null values in remaining data #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an early exit if composed decode hooks are processing a field which is has an untyped nil value. Fixes go-viper#121
stuart-mclaren-hpe
added a commit
to HPE/terraform-provider-hpe
that referenced
this pull request
Jul 23, 2025
Note: we override go-viper/mapstructure temporarily to pick up this fix: go-viper/mapstructure#122 We need to add that override to go.mod in this repo - it doesn't get picked up from the sdk repo.
stuart-mclaren-hpe
added a commit
to HPE/terraform-provider-hpe
that referenced
this pull request
Jul 23, 2025
Note: we override go-viper/mapstructure temporarily to pick up this fix: go-viper/mapstructure#122 We need to add that override to go.mod in this repo - it doesn't get picked up from the sdk repo. Update network datasource to pick up sdk changes - otherwise the code will no longer compile.
stuart-mclaren-hpe
added a commit
to HPE/terraform-provider-hpe
that referenced
this pull request
Jul 23, 2025
Note: we override go-viper/mapstructure temporarily to pick up this fix: go-viper/mapstructure#122 We need to add that override to go.mod in this repo - it doesn't get picked up from the sdk repo. Update network datasource to pick up sdk changes - otherwise the code will no longer compile.
stuart-mclaren-hpe
added a commit
to HPE/terraform-provider-hpe
that referenced
this pull request
Jul 23, 2025
Note: we override go-viper/mapstructure temporarily to pick up this fix: go-viper/mapstructure#122 We need to add that override to go.mod in this repo - it doesn't get picked up from the sdk repo.
naoise-osullivan-hpe
pushed a commit
to HPE/terraform-provider-hpe
that referenced
this pull request
Aug 20, 2025
Note: we override go-viper/mapstructure temporarily to pick up this fix: go-viper/mapstructure#122 We need to add that override to go.mod in this repo - it doesn't get picked up from the sdk repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an early exit if composed decode hooks are processing a field which is has an untyped nil value.
Fixes #121