Streaming robustness proposal #90
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I gave some thought to streaming robustness, and here's an unsolicited/proposal for a change that might help to improve the robustness of streaming. You can provide optional
timeoutandrestartparameters.If
timeoutis provided, theTimelineHttpStreamingandTimelineWebSocketStreamingwill count time since the last successful message (or comment) is received through the stream, and time out if it has been longer than thetimeoutprovided.If
restartistrue(default =true), then on a timeout, it will attempt to reconnect and restart the stream. If not, it'll throw theTimeoutExceptionup the stack.I've not given it a test yet - it's more of a proposal to talk through. What do you think?
Fixes: #89