change pack scripts

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

.github/workflows/build.yml

@@ -17,7 +17,6 @@ jobs:
           cache: 'pnpm'
       - run: pnpm install
       - run: pnpm build
-      - run: pnpm prepare:remove-source-maps
       - run: pnpm package:macos --publish=never -c.mac.identity=null
         env:
           CSC_LINK: ${{ secrets.mac_certs }}
@@ -43,7 +42,6 @@ jobs:
           cache: 'pnpm'
       - run: pnpm install
       - run: pnpm build
-      - run: pnpm prepare:remove-source-maps
       - run: pnpm package:win --publish=never
       - name: Clean up builds
         run: Remove-Item dist/win-unpacked -Recurse
@@ -66,7 +64,6 @@ jobs:
           cache: 'pnpm'
       - run: pnpm install
       - run: pnpm build
-      - run: pnpm prepare:remove-source-maps
       - run: pnpm package:linux --publish=never
       - name: Clean up builds
         run: rm -rfv dist/linux-unpacked

.github/workflows/publish.yml

@@ -24,7 +24,6 @@ jobs:
         env:
           OAUTH_CLIENT_ID: ${{ secrets.oauth_client_id }}
           OAUTH_CLIENT_SECRET: ${{ secrets.oauth_client_secret }}
-      - run: pnpm prepare:remove-source-maps
       - run: pnpm package:macos --publish onTagOrDraft
         env:
           APPLEID_USERNAME: ${{ secrets.appleid_username }}
@@ -56,7 +55,6 @@ jobs:
         env:
           OAUTH_CLIENT_ID: ${{ secrets.oauth_client_id }}
           OAUTH_CLIENT_SECRET: ${{ secrets.oauth_client_secret }}
-      - run: pnpm prepare:remove-source-maps
       - run: pnpm package:win --publish onTagOrDraft
         env:
           GH_TOKEN: ${{ secrets.github_token }}
@@ -82,7 +80,6 @@ jobs:
         env:
           OAUTH_CLIENT_ID: ${{ secrets.oauth_client_id }}
           OAUTH_CLIENT_SECRET: ${{ secrets.oauth_client_secret }}
-      - run: pnpm prepare:remove-source-maps
       - run: pnpm package:linux --publish onTagOrDraft
         env:
           GH_TOKEN: ${{ secrets.github_token }}

package.json

@@ -11,7 +11,6 @@
     "watch": "concurrently --names \"main,renderer\" --prefix-colors \"blue,green\" \"pnpm watch:main\" \"pnpm watch:renderer\"",
     "watch:main": "webpack --watch --config ./config/webpack.config.main.base.ts",
     "watch:renderer": "webpack --watch --config ./config/webpack.config.renderer.base.ts",
-    "prepare:remove-source-maps": "ts-node ./scripts/delete-source-maps.ts",
     "package:linux": "electron-builder --linux",
     "package:macos": "electron-builder --mac",
     "package:win": "electron-builder --win",
@@ -129,6 +128,7 @@
       "repo": "gitify"
     },
     "afterSign": "scripts/notarize.js",
+    "beforeBuild": "scripts/beforeBuild.js",
     "afterPack": "scripts/after-pack.js"
   },
   "dependencies": {

scripts/after-pack.js renamed to scripts/afterPack.js

@@ -1,5 +1,6 @@
 const path = require('node:path');
 const fs = require('node:fs');
+const { chmodSync, chownSync } = require('node:fs');
 const { AfterPackContext } = require('electron-builder');
 
 const packageJson = require('../package.json');
@@ -9,6 +10,9 @@ const electronLanguages = packageJson.build.electronLanguages;
  * @param {AfterPackContext} context
  */
 const afterPack = async (context) => {
+  // biome-ignore lint/suspicious/noConsoleLog: disabled
+  console.log('[afterPack]: Starting...');
+
   const appName = context.packager.appInfo.productFilename;
   const appOutDir = context.appOutDir;
   const platform = context.electronPlatformName;
@@ -18,6 +22,9 @@ const afterPack = async (context) => {
   } else if (platform === 'linux') {
     fixChromeSandboxPermissions(appOutDir);
   }
+
+  // biome-ignore lint/suspicious/noConsoleLog: disabled
+  console.log('[afterPack]: Completed');
 };
 
 /**
@@ -26,6 +33,9 @@ const afterPack = async (context) => {
  * @param {string} appName
  */
 const removeUnusedLocales = (appOutDir, appName) => {
+  // biome-ignore lint/suspicious/noConsoleLog: disabled
+  console.log('[afterPack]: removing unused locales');
+
   const resourcesPath = path.join(
     appOutDir,
     `${appName}.app`,
@@ -58,15 +68,21 @@ const removeUnusedLocales = (appOutDir, appName) => {
  * @param {string} appOutDir
  */
 const fixChromeSandboxPermissions = (appOutDir) => {
+  // biome-ignore lint/suspicious/noConsoleLog: disabled
+  console.log('[afterPack]: fix chrome sandbox permissions');
+
   const chromeSandboxPath = path.join(appOutDir, 'chrome-sandbox');
 
   try {
     chownSync(chromeSandboxPath, 0, 0); // Set root ownership
     chmodSync(chromeSandboxPath, 0o4755); // Set SUID bit
-    // biome-ignore lint/suspicious/noConsoleLog: <explanation>
-    console.log('Fixed chrome-sandbox permissions');
+    // biome-ignore lint/suspicious/noConsoleLog: disabled
+    console.log('[afterPack]: Fixed chrome-sandbox permissions');
   } catch (err) {
-    console.error('Failed to set chrome-sandbox permissions:', err);
+    console.error(
+      '[afterPack]: Failed to set chrome-sandbox permissions:',
+      err,
+    );
   }
 };
 

scripts/beforeBuild.js

@@ -0,0 +1,29 @@
+import fs from 'node:fs';
+import path from 'node:path';
+import { rimrafSync } from 'rimraf';
+const { BeforeBuildContext } = require('electron-builder');
+
+import webpackPaths from '../config/webpack.paths';
+
+/**
+ * @param {BeforeBuildContext} context
+ */
+export default async function beforeBuild(_context) {
+  // biome-ignore lint/suspicious/noConsoleLog: disabled
+  console.log('[beforeBuild]: Starting...');
+
+  deleteSourceMaps();
+
+  // biome-ignore lint/suspicious/noConsoleLog: disabled
+  console.log('[beforeBuild]: Completed');
+}
+
+function deleteSourceMaps() {
+  if (fs.existsSync(webpackPaths.buildPath)) {
+    rimrafSync(path.join(webpackPaths.buildPath, '*.map'), {
+      glob: true,
+    });
+    // biome-ignore lint/suspicious/noConsoleLog: disabled
+    console.log('[beforeBuild]: Deleted source maps');
+  }
+}