Skip to content

Commit 2b9ca4a

Browse files
authored
chore: Update dependencies & tidy up (#444)
* chore: Update more dependencies * feat: Update Octicons * chore: Update Prettier
1 parent f55ee80 commit 2b9ca4a

18 files changed

+198
-209
lines changed

.github/workflows/run-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
run: yarn install
2525

2626
- name: Run Prettier (Check)
27-
run: yarn prettier-check
27+
run: yarn prettier:check
2828

2929
- name: Run Jest
3030
run: yarn test --coverage --runInBand

.prettierrc

Lines changed: 0 additions & 4 deletions
This file was deleted.

.prettierrc.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
module.exports = {
2+
tabWidth: 2,
3+
singleQuote: true,
4+
}

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ The release process is automated. Follow the steps below.
5656
There are 2 checks - one for prettier and one for the unit tests with `jest`.
5757

5858
// Run prettier to check
59-
yarn run prettier-check
59+
yarn run prettier:check
6060

6161
// Run linter & unit tests with coverage
6262
yarn run test

package.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
"make:linux": "electron-builder --linux",
1010
"make:macos": "electron-builder --mac",
1111
"make:win": "electron-builder --win",
12-
"prettier-check": "prettier --check 'src/**/*.{js,ts,tsx}'",
13-
"prettier": "prettier --single-quote --trailing-comma es5 --write 'src/**/*.{js,ts,tsx}'",
12+
"prettier:check": "prettier --check 'src/**/*.{js,ts,tsx}'",
13+
"prettier:apply": "prettier --write 'src/**/*.{js,ts,tsx}'",
1414
"jest": "jest",
1515
"test": "yarn jest",
1616
"start": "electron . -–enable-logging"
@@ -106,9 +106,9 @@
106106
"afterSign": "scripts/notarize.js"
107107
},
108108
"dependencies": {
109-
"@primer/octicons-react": "^9.6.0",
110-
"axios": "=0.19.2",
111-
"date-fns": "^2.11.1",
109+
"@primer/octicons-react": "^11.1.0",
110+
"axios": "=0.21.0",
111+
"date-fns": "^2.16.1",
112112
"electron-updater": "^4.3.5",
113113
"final-form": "^4.19.1",
114114
"lodash": "^4.17.20",
@@ -135,8 +135,8 @@
135135
"devDependencies": {
136136
"@testing-library/react": "^10.0.2",
137137
"@types/jest": "^26.0.15",
138-
"@types/lodash": "^4.14.149",
139-
"@types/node": "^13.11.0",
138+
"@types/lodash": "^4.14.165",
139+
"@types/node": "^14.14.9",
140140
"@types/react": "^16.9.32",
141141
"@types/react-redux": "^7.1.7",
142142
"@types/react-transition-group": "^4.2.4",
@@ -146,7 +146,7 @@
146146
"electron-notarize": "^1.0.0",
147147
"jest": "^26.6.3",
148148
"nock": "^12.0.3",
149-
"prettier": "=2.0.2",
149+
"prettier": "=2.2.0",
150150
"react-test-renderer": "=16.13.1",
151151
"redux-mock-store": "=1.5.4",
152152
"ts-jest": "^26.4.4",

src/js/components/__snapshots__/account-notifications.test.tsx.snap

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -8,24 +8,24 @@ exports[`components/account-notifications.tsx should render itself (github.com w
88
<svg
99
aria-hidden="true"
1010
className="octicon"
11+
dangerouslySetInnerHTML={
12+
Object {
13+
"__html": "<path fill-rule=\\"evenodd\\" d=\\"M12.78 6.22a.75.75 0 010 1.06l-4.25 4.25a.75.75 0 01-1.06 0L3.22 7.28a.75.75 0 011.06-1.06L8 9.94l3.72-3.72a.75.75 0 011.06 0z\\"></path>",
14+
}
15+
}
16+
fill="currentColor"
1117
height={20}
1218
role="img"
1319
style={
1420
Object {
1521
"display": "inline-block",
16-
"fill": "currentColor",
1722
"userSelect": "none",
1823
"verticalAlign": "text-bottom",
1924
}
2025
}
21-
viewBox="0 0 10 16"
22-
width={12.5}
23-
>
24-
<path
25-
d="M5 11L0 6l1.5-1.5L5 8.25 8.5 4.5 10 6l-5 5z"
26-
fillRule="evenodd"
27-
/>
28-
</svg>
26+
viewBox="0 0 16 16"
27+
width={20}
28+
/>
2929
</div>
3030
`;
3131

@@ -37,23 +37,23 @@ exports[`components/account-notifications.tsx should render itself (github.com w
3737
<svg
3838
aria-hidden="true"
3939
className="octicon"
40+
dangerouslySetInnerHTML={
41+
Object {
42+
"__html": "<path fill-rule=\\"evenodd\\" d=\\"M9.78 12.78a.75.75 0 01-1.06 0L4.47 8.53a.75.75 0 010-1.06l4.25-4.25a.75.75 0 011.06 1.06L6.06 8l3.72 3.72a.75.75 0 010 1.06z\\"></path>",
43+
}
44+
}
45+
fill="currentColor"
4046
height={20}
4147
role="img"
4248
style={
4349
Object {
4450
"display": "inline-block",
45-
"fill": "currentColor",
4651
"userSelect": "none",
4752
"verticalAlign": "text-bottom",
4853
}
4954
}
50-
viewBox="0 0 8 16"
51-
width={10}
52-
>
53-
<path
54-
d="M5.5 3L7 4.5 3.25 8 7 11.5 5.5 13l-5-5 5-5z"
55-
fillRule="evenodd"
56-
/>
57-
</svg>
55+
viewBox="0 0 16 16"
56+
width={20}
57+
/>
5858
</div>
5959
`;

src/js/components/__snapshots__/notification.test.tsx.snap

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -11,24 +11,24 @@ exports[`components/notification.js should render itself & its children 1`] = `
1111
aria-hidden="false"
1212
aria-label="Issue"
1313
className="octicon"
14+
dangerouslySetInnerHTML={
15+
Object {
16+
"__html": "<path fill-rule=\\"evenodd\\" d=\\"M8 1.5a6.5 6.5 0 100 13 6.5 6.5 0 000-13zM0 8a8 8 0 1116 0A8 8 0 010 8zm9 3a1 1 0 11-2 0 1 1 0 012 0zm-.25-6.25a.75.75 0 00-1.5 0v3.5a.75.75 0 001.5 0v-3.5z\\"></path>",
17+
}
18+
}
19+
fill="currentColor"
1420
height={20}
1521
role="img"
1622
style={
1723
Object {
1824
"display": "inline-block",
19-
"fill": "currentColor",
2025
"userSelect": "none",
2126
"verticalAlign": "text-bottom",
2227
}
2328
}
24-
viewBox="0 0 14 16"
25-
width={17.5}
26-
>
27-
<path
28-
d="M7 2.3c3.14 0 5.7 2.56 5.7 5.7s-2.56 5.7-5.7 5.7A5.71 5.71 0 011.3 8c0-3.14 2.56-5.7 5.7-5.7zM7 1C3.14 1 0 4.14 0 8s3.14 7 7 7 7-3.14 7-7-3.14-7-7-7zm1 3H6v5h2V4zm0 6H6v2h2v-2z"
29-
fillRule="evenodd"
30-
/>
31-
</svg>
29+
viewBox="0 0 16 16"
30+
width={20}
31+
/>
3232
</div>
3333
<div
3434
className="sc-AxirZ ibrlFv"
@@ -60,24 +60,24 @@ exports[`components/notification.js should render itself & its children 1`] = `
6060
aria-hidden="false"
6161
aria-label="Unsubscribe"
6262
className="octicon"
63+
dangerouslySetInnerHTML={
64+
Object {
65+
"__html": "<path fill-rule=\\"evenodd\\" d=\\"M8 2.75a.75.75 0 00-1.238-.57L3.472 5H1.75A1.75 1.75 0 000 6.75v2.5C0 10.216.784 11 1.75 11h1.723l3.289 2.82A.75.75 0 008 13.25V2.75zM4.238 6.32L6.5 4.38v7.24L4.238 9.68a.75.75 0 00-.488-.18h-2a.25.25 0 01-.25-.25v-2.5a.25.25 0 01.25-.25h2a.75.75 0 00.488-.18zm7.042-1.1a.75.75 0 10-1.06 1.06L11.94 8l-1.72 1.72a.75.75 0 101.06 1.06L13 9.06l1.72 1.72a.75.75 0 101.06-1.06L14.06 8l1.72-1.72a.75.75 0 00-1.06-1.06L13 6.94l-1.72-1.72z\\"></path>",
66+
}
67+
}
68+
fill="currentColor"
6369
height={13}
6470
role="img"
6571
style={
6672
Object {
6773
"display": "inline-block",
68-
"fill": "currentColor",
6974
"userSelect": "none",
7075
"verticalAlign": "text-bottom",
7176
}
7277
}
7378
viewBox="0 0 16 16"
7479
width={13}
75-
>
76-
<path
77-
d="M8 2.81v10.38c0 .67-.81 1-1.28.53L3 10H1c-.55 0-1-.45-1-1V7c0-.55.45-1 1-1h2l3.72-3.72C7.19 1.81 8 2.14 8 2.81zm7.53 3.22l-1.06-1.06-1.97 1.97-1.97-1.97-1.06 1.06L11.44 8 9.47 9.97l1.06 1.06 1.97-1.97 1.97 1.97 1.06-1.06L13.56 8l1.97-1.97z"
78-
fillRule="evenodd"
79-
/>
80-
</svg>
80+
/>
8181
</button>
8282
</div>
8383
</div>
@@ -93,24 +93,24 @@ exports[`components/notification.js should render itself & its children 1`] = `
9393
aria-hidden="false"
9494
aria-label="Mark as Read"
9595
className="octicon"
96+
dangerouslySetInnerHTML={
97+
Object {
98+
"__html": "<path fill-rule=\\"evenodd\\" d=\\"M13.78 4.22a.75.75 0 010 1.06l-7.25 7.25a.75.75 0 01-1.06 0L2.22 9.28a.75.75 0 011.06-1.06L6 10.94l6.72-6.72a.75.75 0 011.06 0z\\"></path>",
99+
}
100+
}
101+
fill="currentColor"
96102
height={20}
97103
role="img"
98104
style={
99105
Object {
100106
"display": "inline-block",
101-
"fill": "currentColor",
102107
"userSelect": "none",
103108
"verticalAlign": "text-bottom",
104109
}
105110
}
106-
viewBox="0 0 12 16"
107-
width={15}
108-
>
109-
<path
110-
d="M12 5l-8 8-4-4 1.5-1.5L4 10l6.5-6.5L12 5z"
111-
fillRule="evenodd"
112-
/>
113-
</svg>
111+
viewBox="0 0 16 16"
112+
width={20}
113+
/>
114114
</button>
115115
</div>
116116
</div>

src/js/components/__snapshots__/repository.test.tsx.snap

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,24 +29,24 @@ Array [
2929
aria-hidden="false"
3030
aria-label="Mark Repository as Read"
3131
className="octicon"
32+
dangerouslySetInnerHTML={
33+
Object {
34+
"__html": "<path fill-rule=\\"evenodd\\" d=\\"M13.78 4.22a.75.75 0 010 1.06l-7.25 7.25a.75.75 0 01-1.06 0L2.22 9.28a.75.75 0 011.06-1.06L6 10.94l6.72-6.72a.75.75 0 011.06 0z\\"></path>",
35+
}
36+
}
37+
fill="currentColor"
3238
height={20}
3339
role="img"
3440
style={
3541
Object {
3642
"display": "inline-block",
37-
"fill": "currentColor",
3843
"userSelect": "none",
3944
"verticalAlign": "text-bottom",
4045
}
4146
}
42-
viewBox="0 0 12 16"
43-
width={15}
44-
>
45-
<path
46-
d="M12 5l-8 8-4-4 1.5-1.5L4 10l6.5-6.5L12 5z"
47-
fillRule="evenodd"
48-
/>
49-
</svg>
47+
viewBox="0 0 16 16"
48+
width={20}
49+
/>
5050
</button>
5151
</div>
5252
</div>,

0 commit comments

Comments
 (0)