Skip to content

Commit f801b52

Browse files
authored
Fix workshop page gutters and interactive target sizing (#2490)
1 parent 2a87d76 commit f801b52

2 files changed

Lines changed: 41 additions & 14 deletions

File tree

scripts/build-docs.test.js

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -86,17 +86,22 @@ test("docs keep accessible responsive gutters and menu target sizes", () => {
8686
const { css } = buildDocs();
8787

8888
assert.ok(css.includes(".menu-toggle,\n.menu-close {\n display: inline-grid;\n flex: 0 0 auto;\n place-items: center;\n width: 44px;\n height: 44px;"));
89-
assert.ok(css.includes(".markdown-body {\n max-width: 650px;\n margin-inline: auto;\n padding-inline: 20px;\n}"));
90-
assert.ok(css.includes("@media (min-width: 480px) {\n .markdown-body {\n padding-inline: 24px;\n }\n}"));
91-
assert.ok(css.includes("@media (min-width: 768px) {\n .markdown-body {\n padding-inline: 32px;\n }\n}"));
92-
assert.ok(css.includes("@media (min-width: 1024px) {\n .markdown-body {\n padding-inline: 48px;\n }\n}"));
93-
assert.ok(css.includes("@media (min-width: 1440px) {\n .markdown-body {\n padding-inline: 64px;\n }\n}"));
89+
assert.ok(css.includes(".workshop-menu-group a {\n display: flex;\n align-items: center;\n box-sizing: border-box;\n min-height: 44px;"));
90+
assert.ok(css.includes(".markdown-body {\n max-width: 650px;\n margin-inline: auto;\n padding-inline: 20px !important;\n}"));
91+
assert.ok(css.includes("@media (min-width: 480px) {\n .markdown-body {\n padding-inline: 24px !important;\n }\n}"));
92+
assert.ok(css.includes("@media (min-width: 768px) {\n .markdown-body {\n padding-inline: 32px !important;\n }\n}"));
93+
assert.ok(css.includes("@media (min-width: 1024px) {\n .markdown-body {\n padding-inline: 48px !important;\n }\n}"));
94+
assert.ok(css.includes("@media (min-width: 1440px) {\n .markdown-body {\n padding-inline: 64px !important;\n }\n}"));
9495
});
9596

9697
test("shared header and code copy controls meet 44px target sizes", () => {
9798
const { css } = buildDocs();
9899

99100
assert.ok(css.includes(".site-title a {\n display: block;\n min-height: 44px;\n box-sizing: border-box;\n padding-block: 10px;\n line-height: 24px;"));
101+
assert.ok(css.includes(".markdown-body details > summary {\n display: inline-flex;\n align-items: center;\n box-sizing: border-box;\n min-height: 44px;\n cursor: pointer;\n}"));
102+
assert.ok(css.includes(".markdown-body a:not(.anchor):not(.workshop-nav-btn),\n.workshop-navigation a:not(.anchor):not(.workshop-nav-btn) {\n display: inline-flex;\n align-items: center;\n min-width: 44px;\n min-height: 44px;"));
103+
assert.ok(css.includes("body > footer a {\n display: inline-flex;\n align-items: center;\n min-width: 44px;\n min-height: 44px;\n}"));
104+
assert.ok(css.includes(".workshop-nav-btn {\n display: inline-flex;\n gap: 0.4em;\n align-items: center;\n box-sizing: border-box;\n min-height: 44px;"));
100105
assert.ok(css.includes(".code-copy-btn {\n position: absolute;\n top: 8px;\n right: 8px;\n display: inline-flex;\n align-items: center;\n justify-content: center;\n min-width: 44px;\n min-height: 44px;"));
101106
});
102107

scripts/lib/docs.css

Lines changed: 31 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,10 @@ html[data-color-mode="dark"] .menu-toggle-progress {
246246
list-style: none;
247247
}
248248
.workshop-menu-group a {
249-
display: block;
249+
display: flex;
250+
align-items: center;
251+
box-sizing: border-box;
252+
min-height: 44px;
250253
padding: 8px;
251254
color: var(--fgColor-default, #1f2328);
252255
line-height: 1.35;
@@ -263,12 +266,19 @@ html[data-color-mode="dark"] .menu-toggle-progress {
263266
background-color: var(--bgColor-accent-muted, #ddf4ff);
264267
}
265268

266-
.markdown-body > details:not([open]) {
267-
display: none;
268-
}
269269
.markdown-body > details {
270270
scroll-margin-top: var(--workshop-sticky-header-offset);
271271
}
272+
.markdown-body details > summary {
273+
display: inline-flex;
274+
align-items: center;
275+
box-sizing: border-box;
276+
min-height: 44px;
277+
cursor: pointer;
278+
}
279+
.markdown-body > details:not([open]) {
280+
display: none;
281+
}
272282
.markdown-body > details > summary {
273283
display: none;
274284
}
@@ -282,30 +292,30 @@ html[data-color-mode="dark"] .menu-toggle-progress {
282292
.markdown-body {
283293
max-width: 650px;
284294
margin-inline: auto;
285-
padding-inline: 20px;
295+
padding-inline: 20px !important;
286296
}
287297

288298
@media (min-width: 480px) {
289299
.markdown-body {
290-
padding-inline: 24px;
300+
padding-inline: 24px !important;
291301
}
292302
}
293303

294304
@media (min-width: 768px) {
295305
.markdown-body {
296-
padding-inline: 32px;
306+
padding-inline: 32px !important;
297307
}
298308
}
299309

300310
@media (min-width: 1024px) {
301311
.markdown-body {
302-
padding-inline: 48px;
312+
padding-inline: 48px !important;
303313
}
304314
}
305315

306316
@media (min-width: 1440px) {
307317
.markdown-body {
308-
padding-inline: 64px;
318+
padding-inline: 64px !important;
309319
}
310320
}
311321
.markdown-body li.task-list-item {
@@ -463,10 +473,20 @@ html[data-color-mode="dark"] .menu-toggle-progress {
463473

464474
.markdown-body a:not(.anchor):not(.workshop-nav-btn),
465475
.workshop-navigation a:not(.anchor):not(.workshop-nav-btn) {
476+
display: inline-flex;
477+
align-items: center;
478+
min-width: 44px;
479+
min-height: 44px;
466480
color: var(--workshop-link-color);
467481
text-decoration: underline;
468482
text-underline-offset: 0.08em;
469483
}
484+
body > footer a {
485+
display: inline-flex;
486+
align-items: center;
487+
min-width: 44px;
488+
min-height: 44px;
489+
}
470490

471491
.markdown-body a:not(.anchor):not(.workshop-nav-btn):visited,
472492
.workshop-navigation a:not(.anchor):not(.workshop-nav-btn):visited {
@@ -505,6 +525,8 @@ html[data-color-mode="dark"] .menu-toggle-progress {
505525
display: inline-flex;
506526
gap: 0.4em;
507527
align-items: center;
528+
box-sizing: border-box;
529+
min-height: 44px;
508530
padding: 8px 16px;
509531
font-size: 14px;
510532
font-weight: 600;

0 commit comments

Comments
 (0)