Update build fixture tests

Author: Harshan01

spec/fixtures/build_error_long_oid.json

@@ -0,0 +1,30 @@
+{
+  "url": "https://api.github.com/repos/github/developer.github.com/pages/builds/5472601",
+  "status": "errored",
+  "error": {
+    "message": "Some message"
+  },
+  "pusher": {
+    "login": "octocat",
+    "id": 1,
+    "avatar_url": "https://github.com/images/error/octocat_happy.gif",
+    "gravatar_id": "",
+    "url": "https://api.github.com/users/octocat",
+    "html_url": "https://github.com/octocat",
+    "followers_url": "https://api.github.com/users/octocat/followers",
+    "following_url": "https://api.github.com/users/octocat/following{/other_user}",
+    "gists_url": "https://api.github.com/users/octocat/gists{/gist_id}",
+    "starred_url": "https://api.github.com/users/octocat/starred{/owner}{/repo}",
+    "subscriptions_url": "https://api.github.com/users/octocat/subscriptions",
+    "organizations_url": "https://api.github.com/users/octocat/orgs",
+    "repos_url": "https://api.github.com/users/octocat/repos",
+    "events_url": "https://api.github.com/users/octocat/events{/privacy}",
+    "received_events_url": "https://api.github.com/users/octocat/received_events",
+    "type": "User",
+    "site_admin": false
+  },
+  "commit": "fedcba9876543210fedcba9876543210fedcba9876543210fedcba9876543210",
+  "duration": 2104,
+  "created_at": "2014-02-10T19:00:49Z",
+  "updated_at": "2014-02-10T19:00:51Z"
+}

spec/fixtures/build_success_long_oid.json

@@ -0,0 +1,30 @@
+{
+  "url": "https://api.github.com/repos/github/developer.github.com/pages/builds/5472601",
+  "status": "built",
+  "error": {
+    "message": null
+  },
+  "pusher": {
+    "login": "octocat",
+    "id": 1,
+    "avatar_url": "https://github.com/images/error/octocat_happy.gif",
+    "gravatar_id": "",
+    "url": "https://api.github.com/users/octocat",
+    "html_url": "https://github.com/octocat",
+    "followers_url": "https://api.github.com/users/octocat/followers",
+    "following_url": "https://api.github.com/users/octocat/following{/other_user}",
+    "gists_url": "https://api.github.com/users/octocat/gists{/gist_id}",
+    "starred_url": "https://api.github.com/users/octocat/starred{/owner}{/repo}",
+    "subscriptions_url": "https://api.github.com/users/octocat/subscriptions",
+    "organizations_url": "https://api.github.com/users/octocat/orgs",
+    "repos_url": "https://api.github.com/users/octocat/repos",
+    "events_url": "https://api.github.com/users/octocat/events{/privacy}",
+    "received_events_url": "https://api.github.com/users/octocat/received_events",
+    "type": "User",
+    "site_admin": false
+  },
+  "commit": "0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef",
+  "duration": 2104,
+  "created_at": "2014-02-10T19:00:49Z",
+  "updated_at": "2014-02-10T19:00:51Z"
+}

spec/github_pages_health_check/repository_spec.rb

@@ -50,58 +50,65 @@
     end
   end
 
-  %w(error success).each do |type|
-    context "a build that was a(n) #{type}" do
-      let(:access_token) { "1234" }
-      let(:fixture) { File.read(fixture_path("build_#{type}.json")) }
-      let(:url) { "https://api.github.com/repos/#{repo}/pages/builds/latest" }
-
-      before do
-        stub_request(:get, url)
-          .to_return(:status => 200,
-                     :body => fixture,
-                     :headers => { "Content-Type" => "application/json" })
-      end
-
-      if type == "error"
-        it "fails the check" do
-          build_error = GitHubPages::HealthCheck::Errors::BuildError
-          expect { subject.check! }.to raise_error(build_error)
+  builds = {
+    "error" => %w[build_error.json build_error_long_oid.json],
+    "success" => %w[build_success.json build_success_long_oid.json],
+  }
+
+  builds.each do |type, fixtures|
+    fixtures.each do |fixture_name|
+      context "a build that was a(n) #{type} using #{fixture_name}" do
+        let(:access_token) { "1234" }
+        let(:fixture) { File.read(fixture_path(fixture_name)) }
+        let(:expected_commit) { JSON.parse(fixture).fetch("commit") }
+        let(:url) { "https://api.github.com/repos/#{repo}/pages/builds/latest" }
+
+        before do
+          stub_request(:get, url)
+            .to_return(:status => 200,
+                       :body => fixture,
+                       :headers => { "Content-Type" => "application/json" })
         end
 
-        it "returns the build error" do
-          expect(subject.build_error).to eql("Some message")
+        if type == "error"
+          it "fails the check" do
+            build_error = GitHubPages::HealthCheck::Errors::BuildError
+            expect { subject.check! }.to raise_error(build_error)
+          end
+
+          it "returns the build error" do
+            expect(subject.build_error).to eql("Some message")
+          end
+
+          it "knows the site wasn't built" do
+            expect(subject.built?).to be_falsy
+          end
+        else
+          it "passes the check" do
+            expect(subject.check!).to be_truthy
+          end
+
+          it "returns no build error" do
+            expect(subject.build_error).to be_nil
+          end
+
+          it "knows the site was built" do
+            expect(subject.built?).to be_truthy
+          end
         end
 
-        it "knows the site wasn't built" do
-          expect(subject.built?).to be_falsy
-        end
-      else
-        it "passes the check" do
-          expect(subject.check!).to be_truthy
+        it "returns the commit OID" do
+          expect(subject.last_build["commit"]).to eql(expected_commit)
         end
 
-        it "returns no build error" do
-          expect(subject.build_error).to be_nil
+        it "knows the build duration" do
+          expect(subject.build_duration).to eql(2104)
         end
 
-        it "knows the site was built" do
-          expect(subject.built?).to be_truthy
+        it "knows when it was last built" do
+          expect(subject.last_built.to_s).to match(/2014-02-10/)
         end
       end
-
-      it "returns the build info" do
-        expected = "351391cdcb88ffae71ec3028c91f375a8036a26b"
-        expect(subject.last_build["commit"]).to eql(expected)
-      end
-
-      it "knows the build duration" do
-        expect(subject.build_duration).to eql(2104)
-      end
-
-      it "knows when it was last built" do
-        expect(subject.last_built.to_s).to match(/2014-02-10/)
-      end
     end
   end