ignore if ref doesn't exist on remote

Author: skarim

cmd/link.go

@@ -161,9 +161,10 @@ func pushBranchArgs(cfg *config.Config, opts *linkOptions, args []string) error
 		return ErrSilent
 	}
 
-	if err := git.FetchBranches(remote, branches); err != nil {
-		cfg.Warningf("Failed to fetch branches from %s: %v", remote, err)
-	}
+	// Best-effort fetch to update tracking refs (helps --force-with-lease
+	// in shallow clones). Silently ignored if branches don't exist on the
+	// remote yet.
+	_ = git.FetchBranches(remote, branches)
 
 	cfg.Printf("Pushing %d %s to %s...", len(branches), plural(len(branches), "branch", "branches"), remote)
 	if err := git.Push(remote, branches, false, true); err != nil {

cmd/push.go

@@ -93,9 +93,10 @@ func runPush(cfg *config.Config, opts *pushOptions) error {
 		cfg.Printf("No active branches to push (all merged or queued)")
 		return nil
 	}
-	if err := git.FetchBranches(remote, activeBranches); err != nil {
-		cfg.Warningf("Failed to fetch branches from %s: %v", remote, err)
-	}
+	// Best-effort fetch to update tracking refs (helps --force-with-lease
+	// in shallow clones). Silently ignored if branches don't exist on the
+	// remote yet.
+	_ = git.FetchBranches(remote, activeBranches)
 	cfg.Printf("Pushing %d %s to %s...", len(activeBranches), plural(len(activeBranches), "branch", "branches"), remote)
 	if err := git.Push(remote, activeBranches, true, false); err != nil {
 		cfg.Errorf("failed to push: %s", err)

cmd/push_test.go

@@ -262,7 +262,7 @@ func TestPush_FetchFailureIsNonFatal(t *testing.T) {
 
 	assert.NoError(t, err, "fetch failure should not abort push")
 	assert.True(t, pushCalled, "push should proceed after fetch failure")
-	assert.Contains(t, string(errOut), "Failed to fetch")
+	assert.NotContains(t, string(errOut), "Failed to fetch", "fetch failure should be silent")
 }
 
 func TestPush_DoesNotCreatePRs(t *testing.T) {

cmd/submit.go

@@ -59,6 +59,8 @@ func runSubmit(cfg *config.Config, opts *submitOptions) error {
 		return ErrNotInStack
 	}
 
+	cfg.Printf("Checking stack state...")
+
 	// Find the stack for the current branch without switching branches.
 	// Submit should never change the user's checked-out branch.
 	stacks := sf.FindAllStacksForBranch(currentBranch)
@@ -141,12 +143,10 @@ func runSubmit(cfg *config.Config, opts *submitOptions) error {
 		}
 	}
 
-	// Fetch the active branches from the remote so that the local tracking refs
-	// are up-to-date before pushing. This ensures --force-with-lease has accurate
-	// remote state even in shallow clones.
-	if err := git.FetchBranches(remote, activeBranches); err != nil {
-		cfg.Warningf("Failed to fetch branches from %s: %v", remote, err)
-	}
+	// Best-effort fetch to update tracking refs (helps --force-with-lease
+	// in shallow clones). Silently ignored if branches don't exist on the
+	// remote yet.
+	_ = git.FetchBranches(remote, activeBranches)
 
 	// Push each branch and create/update its PR in stack order (bottom to top).
 	// Sequential pushing ensures each branch's base is up-to-date on the