fix: address lint and PR comment issues

Author: ajbeattie

internal/controller/controller_test.go

@@ -44,11 +44,11 @@ func (m *mockPoster) getCalls() int {
 // mockResolver is a test double for the workloadResolver interface.
 type mockResolver struct{}
 
-func (m *mockResolver) Resolve(pod *corev1.Pod) workload.Identity {
+func (*mockResolver) Resolve(_ *corev1.Pod) workload.Identity {
 	return workload.Identity{}
 }
 
-func (m *mockResolver) IsActive(_ string, _ workload.Identity) bool {
+func (*mockResolver) IsActive(_ string, _ workload.Identity) bool {
 	return false
 }
 

internal/workload/workload.go

@@ -74,14 +74,29 @@ func (r *Resolver) Resolve(pod *corev1.Pod) Identity {
 func (r *Resolver) IsActive(namespace string, ref Identity) bool {
 	switch ref.Kind {
 	case "Deployment":
+		if r.deploymentLister == nil {
+			return false
+		}
 		return r.deploymentExists(namespace, ref.Name)
 	case "DaemonSet":
+		if r.daemonSetLister == nil {
+			return false
+		}
 		return r.daemonSetExists(namespace, ref.Name)
 	case "StatefulSet":
+		if r.statefulSetLister == nil {
+			return false
+		}
 		return r.statefulSetExists(namespace, ref.Name)
 	case "CronJob":
+		if r.cronJobLister == nil {
+			return false
+		}
 		return r.cronJobExists(namespace, ref.Name)
 	case "Job":
+		if r.jobLister == nil {
+			return false
+		}
 		return r.jobExists(namespace, ref.Name)
 	default:
 		return false

internal/workload/workload_test.go

@@ -317,20 +317,21 @@ func TestIsTerminalPhase(t *testing.T) {
 func TestIsNumeric(t *testing.T) {
 	t.Parallel()
 	tests := []struct {
+		name     string
 		input    string
 		expected bool
 	}{
-		{"28485120", true},
-		{"0", true},
-		{"123456789", true},
-		{"", false},
-		{"abc", false},
-		{"123abc", false},
-		{"12-34", false},
+		{"digits", "28485120", true},
+		{"zero", "0", true},
+		{"long digits", "123456789", true},
+		{"empty string", "", false},
+		{"letters", "abc", false},
+		{"mixed", "123abc", false},
+		{"hyphenated", "12-34", false},
 	}
 
 	for _, tt := range tests {
-		t.Run(tt.input, func(t *testing.T) {
+		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 			assert.Equal(t, tt.expected, isNumeric(tt.input))
 		})