Apply suggestions from code review

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Author: ajbeattie

internal/controller/reporting.go

@@ -213,7 +213,7 @@ type syncCandidate struct {
 func (c *Controller) makeSyncRecords(ctx context.Context, syncClusterPods []any) []*deploymentrecord.Record {
 	// The API requires a unique set of deployment_names for a snapshot job.
 	// During a rollout the same deployment_name can appear with multiple digests
-	// (old and new pods running at once), so we must collapse to a single digest per workload +
+	// (old and new pods running at once), so we must collapse to a single digest per workload and
 	// container name. We pick the newest running pod so the snapshot reflects the rollout target.
 	winners := make(map[string]syncCandidate)
 	for _, p := range syncClusterPods {
@@ -244,7 +244,7 @@ func (c *Controller) makeSyncRecords(ctx context.Context, syncClusterPods []any)
 		allContainers = append(allContainers, pod.Spec.InitContainers...)
 
 		// Dedupe to one record per deployment_name. On a digest conflict
-		// (rollout in progress) the newest running pod wins.
+		// (rollout in progress) the preferred pod wins (running over terminal; otherwise newest).
 		for _, container := range allContainers {
 			dn := getARDeploymentName(pod, container, c.cfg.Template, wl.Name)
 			digest := getContainerDigest(pod, container.Name)
@@ -271,7 +271,7 @@ func (c *Controller) makeSyncRecords(ctx context.Context, syncClusterPods []any)
 			// Keep the newest running pod's digest and log the decision so the
 			// rollout is visible.
 			if isPreferredSyncPod(pod, existing.pod) {
-				slog.Info("Multiple digests observed for deployment_name during sync, choosing newest running",
+				slog.Info("Multiple digests observed for deployment_name during sync, choosing preferred pod",
 					"deployment_name", dn,
 					"chosen_pod", pod.Name,
 					"chosen_digest", digest,
@@ -280,7 +280,7 @@ func (c *Controller) makeSyncRecords(ctx context.Context, syncClusterPods []any)
 				)
 				winners[dn] = syncCandidate{pod: pod, container: container, wlName: wl.Name}
 			} else {
-				slog.Info("Multiple digests observed for deployment_name during sync, keeping newest running",
+				slog.Info("Multiple digests observed for deployment_name during sync, keeping preferred pod",
 					"deployment_name", dn,
 					"kept_pod", existing.pod.Name,
 					"kept_digest", existingDigest,