Skip to content

Commit 5e9d02e

Browse files
authored
According to copilot and human reasoning, the execute bit was not set and caused the failure (#1497)
Re-enable Java JaCoCo badge update steps On branch edburns/fix-jacoco-failure-on-main modified: .github/workflows/java-sdk-tests.yml - Follow convention and invoke script via `bash` rather than assuming the execute bit is set.
1 parent 4633cc2 commit 5e9d02e

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

.github/scripts/generate-java-coverage-badge.sh

100644100755
File mode changed.

.github/workflows/java-sdk-tests.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,12 +118,12 @@ jobs:
118118
retention-days: 1
119119

120120
- name: Generate JaCoCo badge
121-
if: false # Disabled because it always fails on main
121+
if: success() && github.ref == 'refs/heads/main' && matrix.test-jdk == '25'
122122
working-directory: .
123-
run: .github/scripts/generate-java-coverage-badge.sh java/target/site/jacoco-coverage/jacoco.csv .github/badges
123+
run: bash .github/scripts/generate-java-coverage-badge.sh java/target/site/jacoco-coverage/jacoco.csv .github/badges
124124

125125
- name: Create PR for JaCoCo badge update
126-
if: false # Disabled because it always fails on main
126+
if: success() && github.ref == 'refs/heads/main' && matrix.test-jdk == '25'
127127
uses: peter-evans/create-pull-request@5f6978faf089d4d20b00c7766989d076bb2fc7f1 # v7
128128
with:
129129
commit-message: "Update Java JaCoCo coverage badge"

0 commit comments

Comments
 (0)