Skip to content

Commit 056ff6e

Browse files
tclemCopilot
andcommitted
Document infinite_sessions parity + Client::stop deferral (Bucket A.2/A.6)
Notes-only CHANGELOG entries closing out the remaining Bucket A items: * A.2 (infinite_sessions) — already wired on both SessionConfig and ResumeSessionConfig as `Option<InfiniteSessionConfig>` with default-omit-on-the-wire semantics. Matches Node/Go (CLI-applied defaults when the field is absent). No code change; document the parity decision so it doesn't get re-flagged. * A.6 (Client::stop error aggregation) — defer behind a Client-level session registry. Real aggregation requires iterating Session handles to disconnect-then-kill, but the Rust Client only tracks per-session channel senders today (router::SessionSenders), not Session instances. A cosmetic Result<(), Vec<Error>> change with no behavior shift would be pure pass-through wrapping. Tracked for Bucket B alongside the registry refactor. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 7068f87 commit 056ff6e

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

rust/CHANGELOG.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,3 +161,15 @@ public surface.
161161
so the concept doesn't apply. See `Client::from_streams` rustdoc.
162162
- `cargo semver-checks` runs in `continue-on-error` mode for 0.1.0; will
163163
flip to blocking once 0.1.0 is published and serves as the baseline.
164+
- `infinite_sessions: Option<InfiniteSessionConfig>` is wired on both
165+
`SessionConfig` and `ResumeSessionConfig` and follows the same
166+
default-omit-on-the-wire semantics as Node/Go: when `None`, the field
167+
is skipped and the CLI applies its own default. No behavioral
168+
divergence from the other SDKs.
169+
- `Client::stop` returns `Result<(), Error>` and currently kills the CLI
170+
child process on the first failure rather than aggregating shutdown
171+
errors across active sessions (Node returns `Error[]`). The Rust
172+
`Client` does not yet hold strong/weak handles to its `Session`s — the
173+
router only tracks per-session channel senders — so there is nothing
174+
to iterate disconnect-then-kill across. Aggregation will land alongside
175+
a Client-level session registry; tracked as Bucket B.

0 commit comments

Comments
 (0)