Merge pull request #13361 from github/nickrolfe/csharp-location-tostring

C#: avoid calls to `Location::toString()`

Author: nickrolfe

csharp/ql/src/Bad Practices/Implementation Hiding/ExposeRepresentation.ql

@@ -78,4 +78,4 @@ where
   exposesByStore(c, f, why, whyText)
 select c,
   "'" + c.getName() + "' exposes the internal representation stored in field '" + f.getName() +
-    "'. The value may be modified $@.", why.getLocation(), whyText
+    "'. The value may be modified $@.", why, whyText

csharp/ql/src/Complexity/ComplexCondition.ql

@@ -26,4 +26,4 @@ where
   operators =
     count(BinaryLogicalOperation op | logicalParent*(op, e) and nontrivialLogicalOperator(op)) and
   operators > 3
-select e.getLocation(), "Complex condition: too many logical operations in this expression."
+select e, "Complex condition: too many logical operations in this expression."

csharp/ql/test/query-tests/Bad Practices/Implementation Hiding/ExposeRepresentation/ExposeRepresentation.expected

@@ -1,2 +1,2 @@
-| ExposeRepresentation.cs:8:21:8:23 | Set | 'Set' exposes the internal representation stored in field 'rarray'. The value may be modified $@. | ExposeRepresentation.cs:16:9:16:9 | ExposeRepresentation.cs:16:9:16:9 | through the variable a |
-| ExposeRepresentationBad.cs:18:22:18:24 | Get | 'Get' exposes the internal representation stored in field 'rarray'. The value may be modified $@. | ExposeRepresentationBad.cs:24:23:24:29 | ExposeRepresentationBad.cs:24:23:24:29 | after this call to Get |
+| ExposeRepresentation.cs:8:21:8:23 | Set | 'Set' exposes the internal representation stored in field 'rarray'. The value may be modified $@. | ExposeRepresentation.cs:16:9:16:9 | access to local variable a | through the variable a |
+| ExposeRepresentationBad.cs:18:22:18:24 | Get | 'Get' exposes the internal representation stored in field 'rarray'. The value may be modified $@. | ExposeRepresentationBad.cs:24:23:24:29 | call to method Get | after this call to Get |