Skip to content

Commit 6847fba

Browse files
committed
release: sign .deb files with a stronger algorithm
It has been reported in #2028 that Git Credential Manager's `.deb` files cannot be validated with `debsig-verify`. A deeper investigation brought to light that the reason is a weak digest algorithm: `debsigs` calls `gpg --opengpg` which uses SHA-1, but `debsig-verify` rejects such weak signatures. This was actually already fixed in `debsigs`, but current Ubuntu versions will not get those fixes, being stuck with older `debsigs` versions. It's easy enough to work around, though, so let's do that. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent ede8541 commit 6847fba

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

.github/workflows/release.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,15 @@ jobs:
270270
# Install debsigs
271271
sudo apt install debsigs
272272
273+
# Stop using SHA-1 for the signature. For details, see
274+
# https://gitlab.com/debsigs/debsigs/-/commit/75c6c8f96e6cdc33bca9c5f32195b68ff35bc32f
275+
# which seems to have made it to have made it into debsigs v0.2.1, but Ubuntu 24.04 is
276+
# stuck with v1.19.
277+
mkdir -p patched-debsigs &&
278+
sed 's/, "--openpgp"//' </usr/bin/debsigs >patched-debsigs/debsigs &&
279+
chmod a+x patched-debsigs/debsigs &&
280+
echo "$PWD/patched-debsigs" >>$GITHUB_PATH
281+
273282
# Download GPG key, passphrase, and keygrip from Azure Key Vault
274283
key=$(az keyvault secret show --name $GPG_KEY_SECRET_NAME --vault-name $AZURE_VAULT --query "value")
275284
passphrase=$(az keyvault secret show --name $GPG_PASSPHRASE_SECRET_NAME --vault-name $AZURE_VAULT --query "value")

0 commit comments

Comments
 (0)