Skip to content

Conversation

@ghinks
Copy link
Owner

@ghinks ghinks commented Nov 11, 2025

for issue 174

for issue [174]($#174)
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 95 to 97

# Handle rate limiting (existing logic)
backoff_if_ratelimited(response.headers)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Respect rate-limit reset before retrying pull request fetch

In _make_pr_request_with_retry the loop now continues for retryable statuses before calling backoff_if_ratelimited. For responses like 429 the exponential backoff runs but the code ignores X-RateLimit-Reset, so retries fire immediately and exhaust MAX_RETRIES even though waiting until the reset would succeed. The previous version always slept using the rate-limit headers, so this change regresses handling of GitHub rate limits.

Useful? React with 👍 / 👎.

@ghinks ghinks merged commit 4c8cb9e into main Nov 12, 2025
9 checks passed
@ghinks ghinks deleted the feat/fail-fast-invalid-repo-174 branch November 12, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants