Skip to content

Conversation

@ghinks
Copy link
Owner

@ghinks ghinks commented Nov 3, 2025

Summary

  • Adds integration test infrastructure to verify that the local development version produces the same output as the latest released version from PyPI
  • Test runs review-tally against the expressjs organization (March 2025) and performs semantic comparison of results
  • Outputs are saved to timestamped files for debugging

Changes

  • New integration test: tests/integration/test_version_comparison.py
    • Parses and semantically compares tabulated output between local and released versions
    • Saves outputs to tests/integration/outputs/ with timestamps
    • Requires GITHUB_TOKEN environment variable
    • Fails with clear error if released version not installed

ghinks and others added 9 commits November 3, 2025 14:32
Creates integration test infrastructure to verify that the local development version produces the same output as the latest released version from PyPI. The test runs review-tally against the expressjs organization and performs semantic comparison of the tabulated results.

Key changes:
- New integration test in tests/integration/test_version_comparison.py
- Parses and semantically compares tabulated output
- Saves outputs to timestamped files for debugging
- CI workflow updated to install latest release and run integration tests
- Unit tests now skip integration tests by default
- Added pytest marker for integration tests

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Fixes ruff linting errors in the integration test:
- Add UTC timezone to datetime.now() call
- Combine nested if statements
- Add FLOAT_TOLERANCE constant for magic value
- Update docstring formatting
- Add trailing commas per style guide
- Add per-file-ignores for integration test specific rules (C901, PLR0912, S603, T201)

All checks now pass:
- ruff check ✓
- mypy ✓
- pytest ✓

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Updates the integration test to run the local version using 'poetry run python' 
instead of just 'python' to ensure it runs within the Poetry virtual environment 
with the correct dependencies.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@ghinks ghinks mentioned this pull request Nov 6, 2025
@ghinks ghinks merged commit 0eb5cf0 into main Nov 6, 2025
9 checks passed
@ghinks ghinks deleted the feat/integration-test branch November 6, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants