fix: typecheck regression and dead code cleanup after otelia removal

- Fix trailing comma in packages/duron/package.json exports (root cause of TS1295 errors)
- Remove dead spans-related code from dashboard (SpansProvider, spans-panel, spans-context refs)
- Remove unused imports/variables left from otelia removal (adapter.ts, schema.ts, base.ts, test files)
- Run oxfmt on affected files

Author: tinchoz49

bun.lock

@@ -26,13 +26,15 @@ Meanwhile, the OpenTelemetry ecosystem already provides production-grade span st
 Remove `telemetry.local` entirely. Keep the OTel instrumentation (`@opentelemetry/api` context propagation, span creation in `step-manager.ts` and `action-job.ts`) and the `telemetry.traceExporter` path for sending spans to external OTel collectors.
 
 ### What stays
+
 - `@opentelemetry/api` as a regular dependency
 - `ctx.telemetry.span / tracer / track() / flush()` in action contexts
 - Context propagation and automatic span creation
 - `telemetry: { traceExporter: exporter }` configuration
 - `traceExporter` now accepts `SpanExporter | SpanExporter[]`
 
 ### What is removed
+
 - `telemetry.local` option and `LocalTelemetryOptions` type
 - `spans` table from the schema
 - `LocalSpanExporter` class
@@ -44,11 +46,14 @@ Remove `telemetry.local` entirely. Keep the OTel instrumentation (`@opentelemetr
 - `@opentelemetry/sdk-trace-base`, `@opentelemetry/sdk-node`, `@opentelemetry/resources`, `@opentelemetry/semantic-conventions` as direct dependencies
 
 ### New optional peer dependencies
+
 Users who want external OTel export install these themselves:
+
 - `@opentelemetry/sdk-trace-base`
 - `@opentelemetry/sdk-node`
 
 ### Error handling
+
 If `traceExporter` is provided but `@opentelemetry/sdk-node` is not installed, Duron throws at startup with a clear message.
 
 ## Consequences

docs/adr/0001-remove-local-span-storage.md

@@ -5,7 +5,6 @@ import { ApiProvider, type CustomFetch } from './contexts/api-context'
 import { AuthProvider, useAuth } from './contexts/auth-context'
 import { LayoutProvider } from './contexts/layout-context'
 import { PollingProvider } from './contexts/polling-context'
-import { SpansProvider } from './contexts/spans-context'
 import { type ThemeOption, ThemeProvider } from './contexts/theme-context'
 import { Dashboard } from './views/dashboard'
 import Login from './views/login'
@@ -110,14 +109,12 @@ export function DuronDashboard({
           <PollingProvider pollingInterval={pollingInterval}>
             <ApiProvider baseUrl={url} customFetch={customFetch}>
               <AuthProvider>
-                <SpansProvider>
-                  <AppContent
-                    enableLogin={enableLogin}
-                    showLogo={showLogo}
-                    showThemeToggle={showThemeToggle}
-                    className={className}
-                  />
-                </SpansProvider>
+                <AppContent
+                  enableLogin={enableLogin}
+                  showLogo={showLogo}
+                  showThemeToggle={showThemeToggle}
+                  className={className}
+                />
               </AuthProvider>
             </ApiProvider>
           </PollingProvider>

packages/duron-dashboard/src/DuronDashboard.tsx

@@ -19,9 +19,6 @@ const client = duron({
   },
   variables,
   logger: 'info',
-  telemetry: {
-    local: true,
-  },
 })
 
 const app = createServer({
@@ -33,7 +30,6 @@ const app = createServer({
     jwtSecret: process.env.JWT_SECRET || 'dev-secret-key-change-in-production',
     expirationTime: '1d',
   },
-  spansEnabled: true,
 })
 
 const server = serve({

packages/duron-dashboard/src/dev.tsx

@@ -1,6 +1,6 @@
 'use client'
 
-import { Activity, MoreVertical, Play, X } from 'lucide-react'
+import { MoreVertical, Play, X } from 'lucide-react'
 import { useCallback, useEffect, useState } from 'react'
 
 import { Button } from '@/components/ui/button'
@@ -11,15 +11,13 @@ import {
   DropdownMenuTrigger,
 } from '@/components/ui/dropdown-menu'
 import { ScrollArea, ScrollBar } from '@/components/ui/scroll-area'
-import { useSpans } from '@/contexts/spans-context'
 import { useJobStatusPolling } from '@/hooks/use-job-status-polling'
 import { useCancelJob, useDeleteJob, useJob, useRetryJob } from '@/lib/api'
 import { calculateDurationMs, formatMs } from '@/lib/duration'
 import { formatDate } from '@/lib/format'
 
 import { BadgeStatus } from '../components/badge-status'
 import { JsonView } from '../components/json-view'
-import { JobSpansModal } from '../components/spans-panel'
 import { isExpiring } from '../lib/is-expiring'
 
 interface JobDetailsProps {
@@ -29,8 +27,6 @@ interface JobDetailsProps {
 
 export function JobDetails({ jobId, onClose }: JobDetailsProps) {
   const { data: job, isLoading: jobLoading } = useJob(jobId)
-  const { spansEnabled } = useSpans()
-  const [showSpans, setShowSpans] = useState(false)
 
   // Enable polling for job status updates - refetches entire job detail when status changes
   useJobStatusPolling(jobId, true)
@@ -139,12 +135,7 @@ export function JobDetails({ jobId, onClose }: JobDetailsProps) {
                 <Play className="h-4 w-4 mr-2" />
                 Retry
               </DropdownMenuItem>
-              {spansEnabled && (
-                <DropdownMenuItem onClick={() => setShowSpans(!showSpans)}>
-                  <Activity className="h-4 w-4 mr-2" />
-                  {showSpans ? 'Hide Spans' : 'Show Spans'}
-                </DropdownMenuItem>
-              )}
+
               <DropdownMenuItem
                 onClick={handleCancel}
                 disabled={
@@ -300,11 +291,6 @@ export function JobDetails({ jobId, onClose }: JobDetailsProps) {
         </div>
         <ScrollBar orientation="horizontal" />
       </ScrollArea>
-
-      {/* Spans Modal */}
-      {spansEnabled && (
-        <JobSpansModal jobId={job.id} open={showSpans} onClose={() => setShowSpans(false)} />
-      )}
     </div>
   )
 }

packages/duron-dashboard/src/views/job-details.tsx

@@ -1,13 +1,9 @@
 'use client'
 
-import { Activity } from 'lucide-react'
 import { useCallback, useEffect, useState } from 'react'
 
 import { JsonView } from '@/components/json-view'
-import { StepSpansModal } from '@/components/spans-panel'
-import { Button } from '@/components/ui/button'
 import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip'
-import { useSpans } from '@/contexts/spans-context'
 import { useStepStatusPolling } from '@/hooks/use-step-status-polling'
 import { useStep } from '@/lib/api'
 import { calculateDurationMs, formatMs } from '@/lib/duration'
@@ -24,8 +20,6 @@ interface StepDetailsContentProps {
 export function StepDetailsContent({ stepId, jobId }: StepDetailsContentProps) {
   // Fetch the full step data including output
   const { data: step, isLoading, error } = useStep(stepId)
-  const { spansEnabled } = useSpans()
-  const [showSpans, setShowSpans] = useState(false)
 
   // Enable polling for individual step status updates
   useStepStatusPolling(stepId, jobId, true)
@@ -195,21 +189,6 @@ export function StepDetailsContent({ stepId, jobId }: StepDetailsContentProps) {
           </div>
         </div>
       )}
-
-      {/* Spans Button */}
-      {spansEnabled && (
-        <div>
-          <Button variant="outline" size="sm" onClick={() => setShowSpans(true)} className="w-full">
-            <Activity className="h-4 w-4 mr-2" />
-            View Spans
-          </Button>
-        </div>
-      )}
-
-      {/* Spans Modal */}
-      {spansEnabled && (
-        <StepSpansModal stepId={step.id} open={showSpans} onClose={() => setShowSpans(false)} />
-      )}
     </div>
   )
 }

packages/duron-dashboard/src/views/step-details-content.tsx

@@ -2,9 +2,7 @@
   "version": "8",
   "dialect": "postgres",
   "id": "9327c26b-9fb5-47d2-b3ad-1be9a54d551c",
-  "prevIds": [
-    "00000000-0000-0000-0000-000000000000"
-  ],
+  "prevIds": ["00000000-0000-0000-0000-000000000000"],
   "ddl": [
     {
       "name": "duron",
@@ -1789,14 +1787,10 @@
     },
     {
       "nameExplicit": false,
-      "columns": [
-        "job_id"
-      ],
+      "columns": ["job_id"],
       "schemaTo": "duron",
       "tableTo": "jobs_active",
-      "columnsTo": [
-        "id"
-      ],
+      "columnsTo": ["id"],
       "onUpdate": "NO ACTION",
       "onDelete": "CASCADE",
       "name": "job_steps_active_job_id_jobs_active_id_fkey",
@@ -1806,14 +1800,10 @@
     },
     {
       "nameExplicit": false,
-      "columns": [
-        "job_id"
-      ],
+      "columns": ["job_id"],
       "schemaTo": "duron",
       "tableTo": "jobs_archive",
-      "columnsTo": [
-        "id"
-      ],
+      "columnsTo": ["id"],
       "onUpdate": "NO ACTION",
       "onDelete": "CASCADE",
       "name": "job_steps_archive_job_id_jobs_archive_id_fkey",
@@ -1822,49 +1812,39 @@
       "table": "job_steps_archive"
     },
     {
-      "columns": [
-        "id"
-      ],
+      "columns": ["id"],
       "nameExplicit": false,
       "name": "job_steps_active_pkey",
       "schema": "duron",
       "table": "job_steps_active",
       "entityType": "pks"
     },
     {
-      "columns": [
-        "id"
-      ],
+      "columns": ["id"],
       "nameExplicit": false,
       "name": "job_steps_archive_pkey",
       "schema": "duron",
       "table": "job_steps_archive",
       "entityType": "pks"
     },
     {
-      "columns": [
-        "id"
-      ],
+      "columns": ["id"],
       "nameExplicit": false,
       "name": "jobs_active_pkey",
       "schema": "duron",
       "table": "jobs_active",
       "entityType": "pks"
     },
     {
-      "columns": [
-        "id"
-      ],
+      "columns": ["id"],
       "nameExplicit": false,
       "name": "jobs_archive_pkey",
       "schema": "duron",
       "table": "jobs_archive",
       "entityType": "pks"
     },
     {
-      "columns": [
-        "id"
-      ],
+      "columns": ["id"],
       "nameExplicit": false,
       "name": "spans_pkey",
       "schema": "duron",
@@ -1873,11 +1853,7 @@
     },
     {
       "nameExplicit": true,
-      "columns": [
-        "job_id",
-        "name",
-        "parent_step_id"
-      ],
+      "columns": ["job_id", "name", "parent_step_id"],
       "nullsNotDistinct": true,
       "name": "unique_job_step_active_name_parent",
       "entityType": "uniques",
@@ -1928,4 +1904,4 @@
     }
   ],
   "renames": []
-}
+}