Commit c8ee688
authored
Keep message edits expanded on mobile (#4097)
## Human comments
## What was wrong
Sent-message and queued-message edits reused the follow-up composer’s
compact mobile behavior. After focus left an inline edit, its draft
collapsed to a single row and hid the editing controls. There is no
dedicated issue for this layout bug; nearby queued-editing issues
[#1864](#1864) and
[#2401](#2401) are separate.
## What changed
Added an edit-specific expanded preference to `FollowUpPromptBox` and
opted in the main-thread sent and queued editors plus the embedded-chat
queued editor. The derived expanded state drives the compact layout,
mobile CSS, and height animation. The ordinary follow-up composer keeps
its existing default. Synthetic before/after screenshots are in
`docs/assets/message-editing/`.
## How you verified
- `pnpm exec turbo run test typecheck --filter=@bb/app` — 5,077 tests
passed, 6 skipped; typecheck passed.
- `pnpm exec turbo run lint --filter=@bb/app` — 0 errors.
- At 390 px in the source app, opened sent and queued edits and moved
focus away. Before: `compact: true, expanded: false`. After: `compact:
false, expanded: true`.
> AGENT GENERATED1 parent 9e6e455 commit c8ee688
4 files changed
Lines changed: 35 additions & 3 deletions
File tree
- apps/app/src
- components
- promptbox
- thread/embedded-chat
- views/thread-detail
Lines changed: 26 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
917 | 917 | | |
918 | 918 | | |
919 | 919 | | |
| 920 | + | |
| 921 | + | |
| 922 | + | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
| 926 | + | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
| 934 | + | |
| 935 | + | |
| 936 | + | |
| 937 | + | |
| 938 | + | |
| 939 | + | |
| 940 | + | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
| 945 | + | |
920 | 946 | | |
921 | 947 | | |
922 | 948 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
167 | 167 | | |
168 | 168 | | |
169 | 169 | | |
| 170 | + | |
170 | 171 | | |
171 | 172 | | |
172 | 173 | | |
| |||
238 | 239 | | |
239 | 240 | | |
240 | 241 | | |
| 242 | + | |
241 | 243 | | |
242 | 244 | | |
243 | 245 | | |
| |||
296 | 298 | | |
297 | 299 | | |
298 | 300 | | |
| 301 | + | |
| 302 | + | |
299 | 303 | | |
300 | | - | |
| 304 | + | |
301 | 305 | | |
302 | 306 | | |
303 | 307 | | |
| |||
685 | 689 | | |
686 | 690 | | |
687 | 691 | | |
688 | | - | |
| 692 | + | |
689 | 693 | | |
690 | 694 | | |
691 | 695 | | |
| |||
709 | 713 | | |
710 | 714 | | |
711 | 715 | | |
712 | | - | |
| 716 | + | |
713 | 717 | | |
714 | 718 | | |
715 | 719 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1011 | 1011 | | |
1012 | 1012 | | |
1013 | 1013 | | |
| 1014 | + | |
1014 | 1015 | | |
1015 | 1016 | | |
1016 | 1017 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
287 | 287 | | |
288 | 288 | | |
289 | 289 | | |
| 290 | + | |
290 | 291 | | |
291 | 292 | | |
292 | 293 | | |
| |||
0 commit comments