[gephi-lite] Fixes castScalarToModelValue type

Details:
- Clarifies in types that castScalarToModelValue can return undefined
  values
- Fixes various code places that weren't handling properly that cast
  values could indeed be undefined

Author: jacomyal

packages/gephi-lite/src/core/filters/utils.ts

@@ -1,6 +1,6 @@
 import { FilteredGraph, Scalar, gephiLiteStringify } from "@gephi/gephi-lite-sdk";
 import { subgraph } from "graphology-operators";
-import { isNumber } from "lodash";
+import { isNil, isNumber } from "lodash";
 import { DateTime } from "luxon";
 
 import {
@@ -47,7 +47,7 @@ export function filterValue(
         if (value instanceof DateTime || isNumber(value)) {
           return !!filter.keepMissingValues;
         }
-        const strings = Array.isArray(value) ? value : [value];
+        const strings = Array.isArray(value) ? value : !isNil(value) ? [value] : [];
         return strings.some((string) => !filter.terms || filter.terms.has(string));
       }
     }
@@ -100,7 +100,7 @@ export function filterGraph<G extends DatalessGraph | SigmaGraph>(
 
   // Edges:
   else {
-    let edges: string[] = [];
+    let edges: string[];
     if (filter.type === "script") {
       const fullGraph = dataGraphToFullGraph(dataset, graph);
       edges = graph.filterEdges((edgeID) =>

packages/gephi-lite/src/core/graph/fieldModel.ts

@@ -132,25 +132,19 @@ export function inferFieldType(fieldName: string, values: Scalar[], itemsCount:
 export function castScalarToModelValue<T extends FieldModelType = FieldModelType>(
   scalar: Scalar,
   fieldModel: FieldModelTypeSpecCollection[T],
-): FieldModelAbstraction[T]["expectedOutput"] {
+): FieldModelAbstraction[T]["expectedOutput"] | undefined {
   switch (fieldModel.type) {
     case "number":
-      return toNumber(scalar) as FieldModelAbstraction["number"]["expectedOutput"];
+      return toNumber(scalar);
     case "category":
     case "text":
     case "url":
     case "color":
-      return toString(scalar) as FieldModelAbstraction["text"]["expectedOutput"];
+      return toString(scalar) || "";
     case "keywords":
-      return toStringArray(
-        scalar,
-        (fieldModel as FieldModelAbstraction["keywords"]["options"]).separator,
-      ) as FieldModelAbstraction["keywords"]["expectedOutput"];
+      return toStringArray(scalar, (fieldModel as FieldModelAbstraction["keywords"]["options"]).separator);
     case "date":
-      return toDate(
-        scalar,
-        (fieldModel as FieldModelAbstraction["date"]["options"]).format,
-      ) as FieldModelAbstraction["date"]["expectedOutput"];
+      return toDate(scalar, (fieldModel as FieldModelAbstraction["date"]["options"]).format);
     default:
       throw new Error(`Unknown field type ${fieldModel.type}`);
   }

packages/gephi-lite/src/hooks/useDataCollection.ts

@@ -21,7 +21,7 @@ export function useDataCollection(field: FieldModel) {
       }
       case "keywords": {
         for (const itemId in data) {
-          const keywords = castScalarToModelValue<"keywords">(data[itemId][field.id], field);
+          const keywords = castScalarToModelValue<"keywords">(data[itemId][field.id], field) || [];
           for (let i = 0; i < keywords.length; i++) {
             if (!isNil(keywords[i])) values.add(keywords[i]);
           }