Skip to content

Commit 1d4b878

Browse files
committed
[FieldModel] remove deprecated quali/quanti
1 parent 692a16e commit 1d4b878

File tree

13 files changed

+1347
-1629
lines changed

13 files changed

+1347
-1629
lines changed

packages/gephi-lite/src/components/GraphPartitioning/GraphPartitioningForm.tsx

Lines changed: 0 additions & 67 deletions
This file was deleted.

packages/gephi-lite/src/components/GraphPartitioning/GraphPartitioningStatus.tsx

Lines changed: 0 additions & 50 deletions
This file was deleted.

packages/gephi-lite/src/components/GraphPartitioning/index.tsx

Lines changed: 0 additions & 75 deletions
This file was deleted.

packages/gephi-lite/src/components/forms/AttributeSelect.tsx

Lines changed: 0 additions & 67 deletions
This file was deleted.

packages/gephi-lite/src/components/modals/edition/UpdateEdgeModal.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ const UpdateEdgeModal: FC<ModalProps<{ edgeId?: string }>> = ({ cancel, submit,
5858
attributes: edgeFields.map((nf) => ({
5959
key: nf.id,
6060
value: undefined,
61-
...pick(nf, ["qualitative", "quantitative"]),
61+
...pick(nf, ["type", "format", "separator"]),
6262
})),
6363
};
6464

@@ -72,7 +72,7 @@ const UpdateEdgeModal: FC<ModalProps<{ edgeId?: string }>> = ({ cancel, submit,
7272
attributes: edgeFields.map((nf) => ({
7373
key: nf.id,
7474
value: edgeData[edgeId][nf.id],
75-
...pick(nf, ["qualitative", "quantitative"]),
75+
...pick(nf, ["type", "format", "separator"]),
7676
})),
7777
};
7878
}, [edgeData, edgeId, edgeRenderingData, fullGraph, isNew, nodeRenderingData, edgeFields]);

packages/gephi-lite/src/components/modals/edition/UpdateNodeModal.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ const UpdateNodeModal: FC<ModalProps<{ nodeId?: string }>> = ({ cancel, submit,
3434
attributes: nodeFields.map((nf) => ({
3535
key: nf.id,
3636
value: undefined,
37-
...pick(nf, ["qualitative", "quantitative"]),
37+
...pick(nf, ["type", "format", "separator"]),
3838
})),
3939
};
4040

@@ -44,7 +44,7 @@ const UpdateNodeModal: FC<ModalProps<{ nodeId?: string }>> = ({ cancel, submit,
4444
attributes: nodeFields.map((nf) => ({
4545
key: nf.id,
4646
value: nodeData[nodeId][nf.id],
47-
...pick(nf, ["qualitative", "quantitative"]),
47+
...pick(nf, ["type", "format", "separator"]),
4848
})),
4949
};
5050
}, [isNew, nodeId, nodeRenderingData, nodeData, nodeFields]);

packages/gephi-lite/src/core/graph/fieldModel.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@ export function guessSeparator(values: string[]): string | null {
4242

4343
/**
4444
* This function takes an unqualified field model and a list af values, and
45-
* guesses whether that field should be considered qualitative and/or
46-
* quantitative:
45+
* guesses the field type
4746
*/
4847
export function inferFieldType(values: Scalar[], itemsCount: number): FieldModelTypeSpec {
4948
// NUMBER

packages/gephi-lite/src/core/metrics/types.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ export type MetricParameter =
5252
| MetricAttributeParameter
5353
| MetricScriptParameter;
5454

55-
export type MetricType = { string: "qualitative"; type: string | boolean } | { string: "quantitative"; type: number };
56-
5755
export interface Metric<Outputs extends Partial<Record<ItemType, string[]>>> {
5856
id: string;
5957
outputs: {

packages/gephi-lite/src/locales/dev.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@
289289
},
290290
"partitioning": {
291291
"title": "Partitioning",
292-
"description": "To apply appearance or filters differently on different groups of {{items}}, partition your graph using any node qualitative attribute.",
292+
"description": "To apply appearance or filters differently on different groups of {{items}}, partition your graph using any category attribute.",
293293
"partition": "Partition {{items}} on",
294294
"status_no_partition": "{{items}} are not partitioned",
295295
"status_item_preview": "The {{items}} will be grouped into",
@@ -302,10 +302,6 @@
302302
"model": {
303303
"title": "Attributes' Model",
304304
"no_attributes": "There is no attribute in the model yet.",
305-
"attribute": {
306-
"qualitative": "Qualitative",
307-
"quantitative": "Quantitative"
308-
},
309305
"directed": "Directed",
310306
"undirected": "Undirected",
311307
"mixed": "Mixed",

packages/gephi-lite/src/locales/en.json

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@
221221
},
222222
"partitioning": {
223223
"title": "Partitioning",
224-
"description": "To apply appearance or filters differently on different groups of {{items}}, partition your graph using any node qualitative attribute.",
224+
"description": "To apply appearance or filters differently on different groups of {{items}}, partition your graph using any node category attribute.",
225225
"partition": "Partition {{items}} on",
226226
"status_no_partition": "{{items}} are not partitioned",
227227
"status_item_preview": "The {{items}} will be grouped into",
@@ -234,10 +234,6 @@
234234
"model": {
235235
"title": "Attributes' Model",
236236
"no_attributes": "There is no attribute in the model yet.",
237-
"attribute": {
238-
"qualitative": "Qualitative",
239-
"quantitative": "Quantitative"
240-
},
241237
"directed": "Directed",
242238
"undirected": "Undirected",
243239
"mixed": "Mixed",
@@ -316,8 +312,8 @@
316312
},
317313
"local": {
318314
"title": "Save graph locally",
319-
"success":"Graph has been saved locally",
320-
"error":"Failed to save the graph locally"
315+
"success": "Graph has been saved locally",
316+
"error": "Failed to save the graph locally"
321317
}
322318
},
323319
"export": {

0 commit comments

Comments
 (0)