-
Notifications
You must be signed in to change notification settings - Fork 11
Description
I learned that a new jskos-server release is not automatically picked up by bartoc.org, and this can lead to breaking changes if bartoc.org still ships an older bundled version.
I see three possible ways forward:
-
Manual rebuild of the bartoc.org Docker image
We can use a manual workflow button to rebuild/publish the Docker image when needed.
I addedworkflow_dispatchindevfor this (only for admin users) -
Handle it in
Dockerfile
Another option would be to releasebartoc.orgupdatejskos-serverfor example something along these lines:ARG JSKOS_SERVER_REF=v2.4.1 RUN git clone --depth 1 --branch ${JSKOS_SERVER_REF} https://github.com/gbv/jskos-server.git && cd jskos-server && npm ci
-
Longer-term solution
I would prefer a cleaner separation:bartoc.orgshould not be responsible for setting up thejskos-serverinstance for the BARTOC ecosystem. In that setup,bartoc.orgwould only talk to something likejskos-server-bartoc, instead of bundling and managing it itself.