provider name is wrongly unique in Galaxy's OIDC configuration

[martenson]

Currently I cannot have two instances of <provider name="Keycloak"> in oidc_backends_config.xml. I just tested this and the latter declaration of Keycloak overrides the previous one, so that is unfortunate since e.g. Keycloak and oidc are generic providers and Galaxy should be able to connect to multiple instances of such.

This is partially related to https://gist.github.com/martenson/09eec474790d980bc211b8efb6ecc887 since using generic name="oidc" is imho preferable to updating upstream library social-auth-core. However currently Galaxy admins are limited to a single instance of provider name.

@dannon's notes:

• What we have as 'name' should probably be a 'type' the way it's used I guess?
• It'll be a potentially messy migration but it's worth speccing out a ticket for moving to 'type' and 'id' or something, where 'id' is the unique bit.
• We've talked in the past about unifying the various configs for auth into a single 'auth_conf.xml', maybe this is the move.
  (rolling up the various oidc files into a single new auth_conf.xml format)

[dannon]

Thanks for writing this up!

[bgruening]

Outch, we were also bitten by this just now :(