Skip to content

Commit 773a6e0

Browse files
committed
Drop redundant data manager parsing
1 parent 72dddac commit 773a6e0

File tree

2 files changed

+8
-32
lines changed

2 files changed

+8
-32
lines changed

src/ephemeris/_idc_data_managers_to_tools.py

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,6 @@
77
"""
88
import argparse
99
import logging
10-
from typing import (
11-
Dict,
12-
List,
13-
NamedTuple,
14-
)
1510

1611
import yaml
1712

@@ -29,29 +24,10 @@
2924
)
3025

3126

32-
class DataManager(NamedTuple):
33-
tool_id: str
34-
repository_name: str
35-
tags: List[str]
36-
37-
38-
def read_data_managers_configuration(path: str) -> Dict[str, DataManager]:
39-
raw_data_managers = read_data_managers(path)
40-
data_managers: Dict[str, DataManager] = {}
41-
for repository_name, data_manager_configuration in raw_data_managers.__root__.items():
42-
data_manager = DataManager(
43-
tool_id=data_manager_configuration.tool_id,
44-
repository_name=repository_name,
45-
tags=data_manager_configuration.tags or [],
46-
)
47-
data_managers[repository_name] = data_manager
48-
return data_managers
49-
50-
5127
def build_shed_install_conf(path: str) -> dict:
52-
data_managers = read_data_managers_configuration(path)
28+
data_managers = read_data_managers(path)
5329
tools = []
54-
for data_manager in data_managers.values():
30+
for data_manager in data_managers.__root__.values():
5531
tool_id = data_manager.tool_id
5632
tool_id_parts = tool_id.split("/")
5733
repo_owner = tool_id_parts[2]

src/ephemeris/_idc_split_data_manager_genomes.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@
3535
)
3636

3737
from . import get_galaxy_connection
38-
from ._idc_data_managers_to_tools import (
39-
DataManager,
40-
read_data_managers_configuration,
38+
from ._config_models import (
39+
DataManagers,
40+
read_data_managers,
4141
)
4242
from .common_parser import get_common_args
4343
from .ephemeris_log import (
@@ -77,8 +77,8 @@ class SplitOptions:
7777
filters: Filters = Filters()
7878

7979

80-
def tool_id_for(indexer: str, data_managers: Dict[str, DataManager], mode: str) -> str:
81-
data_manager = data_managers[indexer]
80+
def tool_id_for(indexer: str, data_managers: DataManagers, mode: str) -> str:
81+
data_manager = data_managers.__root__[indexer]
8282
assert data_manager, f"Could not find a target data manager for indexer name {indexer}"
8383
tool_shed_guid = data_manager.tool_id
8484
if mode == "short":
@@ -151,7 +151,7 @@ def write_run_data_manager_to_file(run_data_manager: RunDataManager, path: str):
151151

152152

153153
def walk_over_incomplete_runs(split_options: SplitOptions):
154-
data_managers = read_data_managers_configuration(split_options.data_managers_path)
154+
data_managers = read_data_managers(split_options.data_managers_path)
155155
with open(split_options.merged_genomes_path) as f:
156156
genomes_all = yaml.safe_load(f)
157157
genomes = genomes_all["genomes"]

0 commit comments

Comments
 (0)