Skip to content

Async API for Process #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Async API for Process #2880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/app/Fake.Core.Process/Process.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,11 +600,25 @@ module Process =

let startRawSync (processStarter: IProcessStarter) c = (startRaw processStarter c).Result

let startAndAwait (processStarter: IProcessStarter) c =
/// Async version: Starts process and awaits completion without blocking
/// Preferred over 'run' for async workflows to avoid blocking thread pool threads
let startAndAwaitAsync (processStarter: IProcessStarter) c =
start processStarter c |> Async.AwaitTaskWithoutAggregate

/// Legacy: Starts process and awaits completion (blocking)
/// For backward compatibility - prefer startAndAwaitAsync in new code
let startAndAwait (processStarter: IProcessStarter) c =
startAndAwaitAsync processStarter c |> Async.RunSynchronously

/// Async version: Starts process and runs it to completion without blocking
/// Preferred over 'run' for async workflows
let runAsync (processStarter: IProcessStarter) c =
startAndAwaitAsync processStarter c

/// Legacy: Starts process and runs it to completion (blocking)
/// For backward compatibility - prefer runAsync in new code
let run (processStarter: IProcessStarter) c =
startAndAwait processStarter c |> Async.RunSynchronously
runAsync processStarter c |> Async.RunSynchronously

let defaultEnvVar = ProcStartInfoData.defaultEnvVar

Expand Down
Loading