Skip to content

Commit 06f811d

Browse files
KevinRansombaronfel
authored andcommitted
Add fsi to proto build, move version validation to ci only (#6387)
1 parent c4eef3a commit 06f811d

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

eng/Build.ps1

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,10 +189,10 @@ function UpdatePath() {
189189
}
190190

191191
function VerifyAssemblyVersions() {
192-
$fsiPath = Join-Path $ArtifactsDir "bin\fsi\$configuration\net46\fsi.exe"
192+
$fsiPath = Join-Path $ArtifactsDir "bin\fsi\Proto\net46\fsi.exe"
193193

194-
# desktop fsi isn't always built
195-
if (Test-Path $fsiPath) {
194+
# Only verify versions on CI or official build
195+
if ($ci -or $official) {
196196
$asmVerCheckPath = "$RepoRoot\scripts"
197197
Exec-Console $fsiPath """$asmVerCheckPath\AssemblyVersionCheck.fsx"" -- ""$ArtifactsDir"""
198198
}

eng/build-utils.ps1

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -249,9 +249,7 @@ function Make-BootstrapBuild() {
249249
$projectPath = "$RepoRoot\proto.proj"
250250
Run-MSBuild $projectPath "/restore /t:Build" -logFileName "Bootstrap" -configuration $bootstrapConfiguration
251251
Copy-Item "$ArtifactsDir\bin\fsc\$bootstrapConfiguration\$bootstrapTfm\*" -Destination $dir
252-
253-
Write-Host "Cleaning Bootstrap compiler artifacts"
254-
Run-MSBuild $projectPath "/t:Clean" -logFileName "BootstrapClean" -configuration $bootstrapConfiguration
252+
Copy-Item "$ArtifactsDir\bin\fsi\$bootstrapConfiguration\$bootstrapTfm\*" -Destination $dir
255253

256254
return $dir
257255
}

proto.proj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@
1414
<AdditionalProperties Condition="'$(OS)' != 'Unix'">TargetFramework=net46</AdditionalProperties>
1515
<AdditionalProperties Condition="'$(OS)' == 'Unix'">TargetFramework=netcoreapp2.1</AdditionalProperties>
1616
</Projects>
17+
<Projects Include="src\fsharp\fsi\fsi.fsproj">
18+
<AdditionalProperties Condition="'$(OS)' != 'Unix'">TargetFramework=net46</AdditionalProperties>
19+
<AdditionalProperties Condition="'$(OS)' == 'Unix'">TargetFramework=netcoreapp2.1</AdditionalProperties>
20+
</Projects>
1721
</ItemGroup>
1822

1923
<Target Name="Build">

0 commit comments

Comments
 (0)