-
Notifications
You must be signed in to change notification settings - Fork 140
refactor: replaced old pretix/venueless references with eventyay naming #1334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enext
Are you sure you want to change the base?
Changes from 1 commit
d3cfe57
98e1551
bb5277c
b3c5f2c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,15 +11,15 @@ | |
|
|
||
| class PluginApp(_BasePluginConfig): | ||
| default = True | ||
| name = 'pretix_venueless' | ||
| name = 'eventyay-video' | ||
| verbose_name = 'Eventyay Video' | ||
|
|
||
| class PretixPluginMeta: # Keep for upstream pretix compatibility | ||
| class EventyayVideoPluginMeta: # Keep for upstream pretix compatibility | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question (bug_risk): Renaming PretixPluginMeta may break upstream pretix compatibility expectations. This inner class is documented as being for upstream pretix compatibility, but its name changed from |
||
| name = gettext_lazy('Eventyay Video') | ||
| author = 'Eventyay' | ||
| description = gettext_lazy('Grant access to your eventyay video event to your customers.') | ||
| visible = True | ||
| picture = "pretix_venueless/eventyay-logo.192.png" | ||
| picture = "eventyay-video/eventyay-logo.192.png" | ||
| featured = True | ||
| version = __version__ | ||
| category = 'INTEGRATION' | ||
|
|
@@ -29,7 +29,7 @@ class EventyayPluginMeta: # For Eventyay compatibility | |
| author = 'Eventyay' | ||
| description = gettext_lazy('Grant access to your eventyay video event to your customers.') | ||
| visible = True | ||
| picture = "pretix_venueless/eventyay-logo.192.png" | ||
| picture = "eventyay-video/eventyay-logo.192.png" | ||
| featured = True | ||
| version = __version__ | ||
| category = 'INTEGRATION' | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): AppConfig.name should generally be the Python path (likely with underscore) rather than a hyphenated identifier.
In Django AppConfig,
namemust be an importable Python module path.'eventyay-video'is not a valid module name and may break Django’s app registry or pretix’s plugin detection. Please use the actual package/module name instead, e.g.'eventyay_video'.