Fix CSV Export Returns 500 Error (#1267)

* Fix CSV Export Returns 500 Error

* refactor minor fixes

* fix logging usage

---------

Co-authored-by: Mario Behling <[email protected]>

Author: prayag78

app/eventyay/orga/forms/export.py

@@ -79,10 +79,7 @@ def _build_question_fields(self):
     def clean(self):
         data = super().clean()
         if data.get('export_format') == 'csv' and 'data_delimiter' in self.fields and not data.get('data_delimiter'):
-            self.add_error(
-                'data_delimiter',
-                forms.ValidationError(_('Please select a delimiter for your CSV export.')),
-            )
+            data['data_delimiter'] = 'comma'
         return data
 
     def get_object_attribute(self, obj, attribute):
@@ -137,7 +134,7 @@ def csv_export(self, data):
         for row in data:
             for key, value in row.items():
                 if isinstance(value, list):
-                    row[key] = delimiter.join(value)
+                    row[key] = delimiter.join(str(item) for item in value if item is not None)
 
         output = StringIO()
         writer = csv.DictWriter(output, fieldnames=data[0].keys())

app/eventyay/orga/forms/schedule.py

@@ -1,4 +1,6 @@
+import logging
 from django import forms
+from django.db.models import Prefetch
 from django.utils.functional import cached_property
 from django.utils.translation import gettext_lazy as _
 from i18nfield.forms import I18nModelForm
@@ -14,6 +16,9 @@
 from eventyay.base.models.submission import Submission, SubmissionStates
 
 
+logger = logging.getLogger(__name__)
+
+
 class ScheduleReleaseForm(I18nHelpText, I18nModelForm):
     default_renderer = InlineFormRenderer
 
@@ -177,9 +182,13 @@ def get_queryset(self):
         queryset = self.event.submissions
         if 'all' not in target:
             queryset = queryset.filter(state__in=target)
+        queryset = queryset.prefetch_related(
+            Prefetch('slots', queryset=TalkSlot.objects.select_related('room', 'schedule'))
+        )
+        
         return (
-            queryset.prefetch_related('tags')
-            .select_related('submission_type', 'track')
+            queryset.prefetch_related('tags', 'speakers')
+            .select_related('submission_type', 'track', 'event')
             .prefetch_related('resources')
             .order_by('code')
         )
@@ -188,10 +197,19 @@ def get_answer(self, question, obj):
         return question.answers.filter(submission=obj).first()
 
     def _get_speaker_ids_value(self, obj):
-        return list(obj.speakers.all().values_list('code', flat=True))
+        codes = []
+        for code in obj.speakers.all().values_list('code', flat=True):
+            if not code:
+                logger.warning(
+                    "Speaker for submission %s is missing a code.",
+                    getattr(obj, 'id', obj),
+                )
+            else:
+                codes.append(code)
+        return codes
 
     def _get_speaker_names_value(self, obj):
-        return list(obj.speakers.all().values_list('fullname', flat=True))
+        return [name for name in obj.speakers.all().values_list('fullname', flat=True) if name]
 
     def _get_room_value(self, obj):
         slot = obj.slot