Skip to content

Commit 70a8496

Browse files
fix(ui): match top menu bar between eventyay talk and eventyay tickets components (#1259)
* fix(ui): match top menu bar between Eventyay Talk and Tickets components * update font weight --------- Co-authored-by: Mario Behling <[email protected]>
1 parent 0011de0 commit 70a8496

File tree

7 files changed

+172
-59
lines changed

7 files changed

+172
-59
lines changed

app/eventyay/eventyay_common/templates/eventyay_common/base.html

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -168,12 +168,6 @@
168168
<i class="fa fa-solid fa-caret-down"></i>
169169
</a>
170170
</li>
171-
<li>
172-
<a href="{% url 'common:auth.logout' %}" title="{% trans "Log out" %}">
173-
<i class="fa fa-sign-out"></i>
174-
<span class="visible-xs-inline">{% trans "Log out" %}</span>
175-
</a>
176-
</li>
177171
</ul>
178172
<div class="navbar-default sidebar" role="navigation">
179173
<div class="sidebar-nav navbar-nav-collapse navbar-collapse">

app/eventyay/orga/templates/orga/base.html

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -148,15 +148,6 @@
148148
{# The menu built by Vue 3 app will be mounted here. The ID must match. #}
149149
<div id='global-nav-menu' class='d-inline-block' />
150150
</li>
151-
<li class="nav-item">
152-
<form action="{% url "eventyay_common:auth.logout" %}" method="post">
153-
{% csrf_token %}
154-
<button class="nav-link active font-text ml-1" type="submit">
155-
<i class="fa fa-sign-out"></i>
156-
<span>{% trans "Log out" %}</span>
157-
</button>
158-
</form>
159-
</li>
160151
</ul>
161152
</nav>
162153
{% staff_need_to_explain request.user as staff_need_to_explain %}

app/eventyay/static/orga/css/_layout.css

Lines changed: 44 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -438,8 +438,38 @@ aside.sidebar {
438438
}
439439

440440
/* top navbar, /orga only */
441+
442+
.navbar #global-nav-menu {
443+
display: inline-flex;
444+
align-items: center;
445+
vertical-align: middle;
446+
margin-left: 4px;
447+
margin-right: 10px;
448+
font-weight: 500;
449+
}
450+
451+
.navbar #global-nav-menu button {
452+
padding: 0;
453+
line-height: 1;
454+
}
455+
456+
.navbar #global-nav-menu button > div {
457+
width: 0.70rem;
458+
height: 0.70rem;
459+
margin-left: 6px;
460+
}
461+
462+
.navbar .nav-link .fa-user {
463+
margin-right: 5px;
464+
}
465+
466+
.navbar .navbar-nav .nav-item.d-none.d-md-block {
467+
margin-bottom: 0;
468+
}
469+
441470
nav.navbar,
442471
.navbar {
472+
font-weight: 500;
443473
display: flex;
444474
align-items: center;
445475
flex-flow: row nowrap;
@@ -455,15 +485,14 @@ nav.navbar,
455485
background-color: var(--color-primary);
456486
border: 1px solid transparent;
457487
border-color: var(--color-border-navbar);
458-
padding: 0.25rem;
459-
z-index: 200;
488+
padding: .375rem;
489+
padding-right: 1.1rem;
460490

461491
.navbar-brand {
462492
padding-top: 0.3125rem;
463-
font-weight: 600;
464493
padding-bottom: 0.3125rem;
465494
margin-right: 1rem;
466-
font-size: 1.25rem;
495+
font-size: 20px;
467496
line-height: inherit;
468497
white-space: nowrap;
469498
font-family: var(--font-family-title);
@@ -473,7 +502,6 @@ nav.navbar,
473502
vertical-align: middle;
474503
height: 30px;
475504
width: auto;
476-
margin: auto;
477505
}
478506
}
479507

@@ -485,6 +513,14 @@ nav.navbar,
485513
margin-top: 0;
486514
list-style: none;
487515
align-items: center;
516+
517+
&.d-block {
518+
margin-right: 0.5rem;
519+
}
520+
521+
.nav-item.d-none.d-md-block {
522+
margin-right: 16px;
523+
}
488524
}
489525

490526
.nav-link {
@@ -501,6 +537,7 @@ nav.navbar,
501537
a,
502538
button {
503539
color: var(--color-offwhite);
540+
font-size: 14px;
504541

505542
&:hover {
506543
text-decoration: none;
@@ -517,30 +554,8 @@ nav.navbar,
517554
font-weight: normal;
518555
}
519556
}
520-
521-
/* Navigation button styling - sharp corners to match Tickets component */
522-
.header-nav.btn-outline-success,
523-
.header-nav .btn-outline-success,
524-
.header-nav.btn-success,
525-
.header-nav .btn-success {
526-
border-radius: 0 !important;
527-
}
528-
529-
/* Navigation button hover, focus, and active states */
530-
.header-nav.btn-outline-success:hover,
531-
.header-nav.btn-outline-success:focus,
532-
.header-nav.btn-outline-success:active,
533-
.header-nav.btn-outline-success.active {
534-
background-color: var(--color-white);
535-
border-color: var(--color-primary);
536-
color: var(--color-primary);
537-
}
538-
539-
/* Active button inset shadow */
540-
.header-nav.btn-outline-success.active,
541-
.header-nav.btn-success,
542-
.header-nav.btn-success.active {
543-
box-shadow: inset 0 3px 5px rgba(0, 0, 0, 0.125);
557+
.navbar .nav-item form button.nav-link.active {
558+
margin: 0 4px;
544559
}
545560

546561
.speaker-info {
@@ -1683,12 +1698,6 @@ h2 .user-name-display img {
16831698

16841699
ul {
16851700
flex-direction: row;
1686-
1687-
.fa.fa-sign-out {
1688-
padding-left: 12px;
1689-
padding-right: 12px;
1690-
margin-top: 0;
1691-
}
16921701
}
16931702
}
16941703

app/eventyay/static/pretixbase/scss/_variables.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ $navbar-inverse-link-color: white;
4141
$navbar-inverse-link-hover-color: $gray-lighter;
4242
$navbar-inverse-brand-hover-color: $gray-lighter;
4343
$navbar-inverse-color: white;
44+
$navbar-link-color: #f8f9fa;
45+
$navbar-link-hover-color: #fff;
4446

4547
$state-success-bg: white !default;
4648
$state-success-border: $brand-success;

app/eventyay/static/pretixcontrol/scss/_sb-admin-2.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ body {
5050
.navbar-top-links li a {
5151
padding: 15px;
5252
min-height: 50px;
53+
font-size: 14px;
54+
font-weight: normal;
5355
}
5456

5557
.navbar-top-links .dropdown-menu li {

app/eventyay/static/pretixcontrol/scss/_sidebar.scss

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
.navbar-toggle-sidebar {
2-
display: block;
2+
display: flex;
3+
align-items: baseline;
34
float: left;
4-
font-size: 16px;
5+
font-size: 14px;
56
margin-left: 10px;
67
background-color: transparent !important;
78
border: none;
89
padding: 0.5rem;
910
color: #fff;
10-
margin-top: 8px;
11+
margin-top: 12px;
1112
margin-right: 0;
1213
padding-right: 0;
1314
z-index: 1;

app/eventyay/static/pretixcontrol/scss/main.scss

Lines changed: 120 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,16 +39,85 @@ nav.navbar {
3939
left: 0;
4040
right: 0;
4141
z-index: 1100;
42+
font-weight: 500;
43+
44+
&.navbar-inverse {
45+
.navbar-top-links a,
46+
.btn-link {
47+
color: $navbar-link-color;
48+
font-weight: 500;
49+
50+
i {
51+
color: $navbar-link-color;
52+
}
53+
54+
&:hover,
55+
&:focus {
56+
color: $navbar-link-hover-color;
57+
58+
i {
59+
color: $navbar-link-hover-color;
60+
}
61+
}
62+
}
63+
}
4264
}
4365

4466
#wrapper {
4567
padding-top: var(--navbar-height, 50px);
4668
}
4769

48-
.navbar-brand img {
49-
height: 100%;
50-
width: auto;
51-
display: inline;
70+
.navbar-header {
71+
margin-left: 0;
72+
padding-left: 0;
73+
}
74+
75+
nav.navbar.navbar-inverse #sidebar-toggle,
76+
.navbar-inverse #sidebar-toggle {
77+
color: $navbar-link-color;
78+
79+
i.fa-bars {
80+
margin-top: 3px;
81+
color: $navbar-link-color;
82+
}
83+
84+
&:hover,
85+
&:focus {
86+
color: $navbar-link-hover-color;
87+
88+
i.fa-bars {
89+
color: $navbar-link-hover-color;
90+
}
91+
}
92+
}
93+
94+
nav.navbar.navbar-inverse .navbar-brand,
95+
.navbar-inverse .navbar-brand {
96+
padding-top: 0.3125rem;
97+
padding-bottom: 0.3125rem;
98+
margin-right: 1rem;
99+
margin-top: 0;
100+
font-size: 20px;
101+
line-height: inherit;
102+
white-space: nowrap;
103+
font-family: inherit;
104+
display: flex;
105+
align-items: center;
106+
color: $navbar-link-color;
107+
108+
img {
109+
display: inline-block;
110+
vertical-align: middle;
111+
height: 30px;
112+
width: auto;
113+
margin-top: 2px;
114+
margin-right: 0.5rem;
115+
}
116+
117+
&:hover,
118+
&:focus {
119+
color: $navbar-link-hover-color;
120+
}
52121
}
53122

54123
#side-menu img.fa-img {
@@ -58,6 +127,31 @@ nav.navbar {
58127

59128
nav.navbar .danger, nav.navbar .danger:hover, nav.navbar .danger:active {
60129
background: $brand-danger !important;
130+
font-size: 14px;
131+
}
132+
133+
nav.navbar.navbar-inverse .header-nav,
134+
.navbar-inverse .header-nav {
135+
font-size: 14px;
136+
color: $navbar-link-color;
137+
138+
.fa-caret-down {
139+
margin-left: 14px;
140+
margin-right: 10px;
141+
}
142+
143+
i {
144+
color: $navbar-link-color;
145+
}
146+
147+
&:hover,
148+
&:focus {
149+
color: $navbar-link-hover-color;
150+
151+
i {
152+
color: $navbar-link-hover-color;
153+
}
154+
}
61155
}
62156

63157
.navbar-header .navbar-events {
@@ -69,12 +163,29 @@ nav.navbar .danger, nav.navbar .danger:hover, nav.navbar .danger:active {
69163
margin-bottom: 10px;
70164
}
71165

72-
#button-shop, #button-sudo {
166+
nav.navbar.navbar-inverse #button-shop,
167+
nav.navbar.navbar-inverse #button-sudo,
168+
.navbar-inverse #button-shop,
169+
.navbar-inverse #button-sudo {
73170
padding: 15px;
74171
min-height: 50px;
75172
border: none;
76-
&:hover, &:active {
173+
font-size: 14px;
174+
color: $navbar-link-color;
175+
176+
i {
177+
color: $navbar-link-color;
178+
}
179+
180+
&:hover,
181+
&:focus,
182+
&:active {
77183
text-decoration: none;
184+
color: $navbar-link-hover-color;
185+
186+
i {
187+
color: $navbar-link-hover-color;
188+
}
78189
}
79190
}
80191

@@ -423,11 +534,13 @@ body.loading #wrapper {
423534
background-image: none;
424535
border: 1px solid transparent;
425536
border-radius: 4px;
537+
font-weight: normal;
426538
}
427539
}
428540
.mobile-navbar-view-link {
429541
padding: 6px 10px;
430542
color: white !important;
543+
font-weight: normal;
431544
}
432545

433546
@media (min-width: $screen-md-min) {
@@ -1001,3 +1114,4 @@ h1 .label {
10011114
box-sizing: border-box;
10021115
}
10031116
}
1117+

0 commit comments

Comments
 (0)