Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

OMG transferFrom interface is not have return bool value  #36

@baoliang

Description

@baoliang

Hi,
When i deposit the OMG TOKEN
https://etherscan.io/address/0xd26114cd6EE289AccF82350c8d8487fedB8A0C07
, i find run error, i find out The OMG source transferFrom function not return any ,

contract ERC20 is ERC20Basic {
  function allowance(address owner, address spender) constant returns (uint);
  function transferFrom(address from, address to, uint value);
  function approve(address spender, uint value);
  event Approval(address indexed owner, address indexed spender, uint value);
}

but the ERC20 interface is require return bool type value. I find out this project deposit function's ERC20 interface is return bool value.
It run for deposit OMG will error. seems

    require(IToken(token).transferFrom(msg.sender, this, amount));

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions