fix: Fix async s3fs to handle latest changes to FlyteFile (#3223)

* fix: Fix async s3fs to handle latest changes to FlyteFile

* docs: Add to docstring

* fix: Add one more docstring

Signed-off-by: ggydush <[email protected]>

* style: Fix lint issues

* fix: Commit pydoclint file

---------

Signed-off-by: ggydush <[email protected]>

Author: ggydush

plugins/flytekit-async-fsspec/flytekitplugins/async_fsspec/s3fs/s3fs.py

@@ -1,6 +1,7 @@
 import asyncio
 import mimetypes
 import os
+from typing import Any, Callable, Optional
 
 from fsspec.callbacks import _DEFAULT_CALLBACK
 from s3fs import S3FileSystem
@@ -22,21 +23,22 @@ def __init__(self, **s3kwargs):
 
     async def _put_file(
         self,
-        lpath,
-        rpath,
-        callback=_DEFAULT_CALLBACK,
-        chunksize=DEFAULT_UPLOAD_CHUNK_SIZE,
-        concurrent_upload=DEFAULT_CONCURRENT_UPLOAD,
-        **kwargs,
+        lpath: str,
+        rpath: str,
+        callback: Callable = _DEFAULT_CALLBACK,
+        chunksize: int = DEFAULT_UPLOAD_CHUNK_SIZE,
+        concurrent_upload: int = DEFAULT_CONCURRENT_UPLOAD,
+        **kwargs: Any,
     ):
         """
         Put a file from lpath to rpath.
         Args:
             lpath (str): The local path of the file to be uploaded.
             rpath (str): The remote path which the file should be uploaded to.
-            callback (function, optional): The callback function.
-            chunksize (int, optional): Upload chunksize. Defaults to 50 * 2**20 (50MB).
-            concurrent_upload (int, optional): The number of concurrent upload when using multipart upload. Defaults to 4.
+            callback (Callable): The callback function.
+            chunksize (int): Upload chunksize. Defaults to 50 * 2**20 (50MB).
+            concurrent_upload (int): The number of concurrent upload when using multipart upload. Defaults to 4.
+            **kwargs (Any): Additional arguments passed to S3 calls.
         """
         bucket, key, _ = self.split_path(rpath)
         if os.path.isdir(lpath):
@@ -107,21 +109,24 @@ async def upload_chunk(chunk, part_number):
 
     async def _get_file(
         self,
-        rpath,
-        lpath,
-        callback=_DEFAULT_CALLBACK,
-        version_id=None,
-        chunksize=DEFAULT_DOWNLOAD_CHUNK_SIZE,
-        concurrent_download=DEFAULT_CONCURRENT_DOWNLOAD,
+        rpath: str,
+        lpath: str,
+        callback: Callable = _DEFAULT_CALLBACK,
+        version_id: Optional[str] = None,
+        chunksize: int = DEFAULT_DOWNLOAD_CHUNK_SIZE,
+        concurrent_download: int = DEFAULT_CONCURRENT_DOWNLOAD,
+        **kwargs: Any,  # noqa Used for extensibility or future arguments
     ):
         """
         Get a file from rpath to lpath.
         Args:
             rpath (str): The remote path of the file to be downloaded.
             lpath (str): The local path which the file should be downloaded to.
-            callback (function, optional): The callback function.
-            chunksize (int, optional): Download chunksize. Defaults to 50 * 2**20 (50MB).
-            version_id (str, optional): The version id of the file. Defaults to None.
+            callback (Callable): The callback function.
+            version_id (Optional[str]): The version id of the file. Defaults to None.
+            chunksize (int): Download chunksize. Defaults to 50 * 2**20 (50MB).
+            concurrent_download (int): The number of concurrent threads when using multipart download. Defaults to 4.
+            **kwargs (Any): Additional arguments for extensibility or future use.
         """
         if os.path.isdir(lpath):
             return

pydoclint-errors-baseline.txt

@@ -428,15 +428,7 @@ flytekit/types/structured/structured_dataset.py
     DOC301: Class `StructuredDatasetDecoder`: __init__() should not have a docstring; please combine it with the docstring of the class
 --------------------
 plugins/flytekit-async-fsspec/flytekitplugins/async_fsspec/s3fs/s3fs.py
-    DOC101: Method `AsyncS3FileSystem._put_file`: Docstring contains fewer arguments than in function signature.
-    DOC106: Method `AsyncS3FileSystem._put_file`: The option `--arg-type-hints-in-signature` is `True` but there are no argument type hints in the signature
-    DOC107: Method `AsyncS3FileSystem._put_file`: The option `--arg-type-hints-in-signature` is `True` but not all args in the signature have type hints
-    DOC103: Method `AsyncS3FileSystem._put_file`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [**kwargs: ].
     DOC201: Method `AsyncS3FileSystem._put_file` does not have a return section in docstring
-    DOC101: Method `AsyncS3FileSystem._get_file`: Docstring contains fewer arguments than in function signature.
-    DOC106: Method `AsyncS3FileSystem._get_file`: The option `--arg-type-hints-in-signature` is `True` but there are no argument type hints in the signature
-    DOC107: Method `AsyncS3FileSystem._get_file`: The option `--arg-type-hints-in-signature` is `True` but not all args in the signature have type hints
-    DOC103: Method `AsyncS3FileSystem._get_file`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [concurrent_download: ].
     DOC201: Method `AsyncS3FileSystem._get_file` does not have a return section in docstring
 --------------------
 plugins/flytekit-aws-athena/flytekitplugins/athena/task.py